Underlines for preference spinners and other autofill tweaks

Underlines for preference spinners and other autofill tweaks

BUG=414438
Committed: https://crrev.com/fa5c5a845244858359e137057118aead3faf324c
Cr-Commit-Position: refs/heads/master@{#314850}

[Theresa, 2015-02-04 21:48:18]

twellington@chromium.org changed reviewers:
+ newt@chromium.org

[Theresa, 2015-02-04 21:48:19]

Screenshots have been posted in the bug, waiting for a UX response about the
spacing between form fields (which would affect the theme's
floatLabelPaddingTop) but otherwise it should look how they want it to.

[newt (away), 2015-02-04 22:19:09]

ping me once UX is totally happy. thanks!

On Wed, Feb 4, 2015 at 1:48 PM, <twellington@chromium.org> wrote:

> Reviewers: newt,
>
> Message:
> Screenshots have been posted in the bug, waiting for a UX response about
> the
> spacing between form fields (which would affect the theme's
> floatLabelPaddingTop) but otherwise it should look how they want it to.
>
> Description:
> Underlines for preference spinners and other autofill tweaks
>
> BUG=414438
>
> Please review this at https://codereview.chromium.org/897953002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+92, -34 lines):
>   M chrome/android/java/res/color/edit_text_tint.xml
>   M chrome/android/java/res/layout/autofill_credit_card_editor.xml
>   M chrome/android/java/res/layout/autofill_profile_editor.xml
>   M chrome/android/java/res/values-v17/styles.xml
>   M chrome/android/java/res/values-v21/styles.xml
>   M chrome/android/java/res/values/colors.xml
>   M chrome/android/java/res/values/dimens.xml
>   M chrome/android/java/src/org/chromium/chrome/browser/
> preferences/autofill/AutofillCreditCardEditor.java
>   M chrome/android/java/strings/android_chrome_strings.grd
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Theresa, 2015-02-05 18:10:30]

ping, UX is happy :)

[newt (away), 2015-02-05 18:46:12]

nits, then lgtm

https://codereview.chromium.org/897953002/diff/40001/chrome/android/java/res/...
File chrome/android/java/res/color/edit_text_tint.xml (right):

https://codereview.chromium.org/897953002/diff/40001/chrome/android/java/res/...
chrome/android/java/res/color/edit_text_tint.xml:14: <item
android:color="@color/pref_field_underline_color" />
this color isn't specific to preferences, so I'd rename it to
edit_text_underline_color or input_underline_color

https://codereview.chromium.org/897953002/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/897953002/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:59:
mNameText = (EditText) v.findViewById(
don't need to wrap anymore; same below

[Theresa, 2015-02-05 18:52:07]

New patchsets have been uploaded after l-g-t-m from newt@chromium.org

[Theresa, 2015-02-05 18:52:44]

https://codereview.chromium.org/897953002/diff/40001/chrome/android/java/res/...
File chrome/android/java/res/color/edit_text_tint.xml (right):

https://codereview.chromium.org/897953002/diff/40001/chrome/android/java/res/...
chrome/android/java/res/color/edit_text_tint.xml:14: <item
android:color="@color/pref_field_underline_color" />
On 2015/02/05 18:46:12, newt wrote:
> this color isn't specific to preferences, so I'd rename it to
> edit_text_underline_color or input_underline_color

Done.

https://codereview.chromium.org/897953002/diff/40001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
(right):

https://codereview.chromium.org/897953002/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java:59:
mNameText = (EditText) v.findViewById(
On 2015/02/05 18:46:12, newt wrote:
> don't need to wrap anymore; same below

Done.

[Theresa, 2015-02-05 18:52:47]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2015-02-05 18:53:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/897953002/60001

[commit-bot: I haz the power, 2015-02-05 19:14:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-05 19:17:05]

Patchset 4 (id:??) landed as
https://crrev.com/fa5c5a845244858359e137057118aead3faf324c
Cr-Commit-Position: refs/heads/master@{#314850}