Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4411)

Unified Diff: chrome/android/java/res/values-v17/styles.xml

Issue 897953002: Underlines for preference spinners and other autofill tweaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pref_field_underline_color -> input_underline_color, fix wrapping Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/values-v17/styles.xml
diff --git a/chrome/android/java/res/values-v17/styles.xml b/chrome/android/java/res/values-v17/styles.xml
index 18f7f5677f7dc8b506291942e5d029fe9e32a258..978967dfa2b60305d239e9e49cf2e850dc1c72cd 100644
--- a/chrome/android/java/res/values-v17/styles.xml
+++ b/chrome/android/java/res/values-v17/styles.xml
@@ -11,7 +11,11 @@
<item name="android:buttonStyle">@style/PreferenceButtonStyle</item>
<item name="android:textAppearanceMedium">@style/PreferenceTextAppearanceMedium</item>
<item name="android:preferenceCategoryStyle">@style/PreferenceCategory</item>
+ <item name="android:spinnerItemStyle">@style/PreferenceSpinnerItem</item>
<item name="floatLabelTextAppearance">@style/PreferenceFloatLabelTextAppearance</item>
+ <item name="floatLabelPaddingLeft">@dimen/pref_autofill_field_horizontal_padding</item>
+ <item name="floatLabelPaddingRight">@dimen/pref_autofill_field_horizontal_padding</item>
+ <item name="floatLabelPaddingTop">@dimen/pref_autofill_field_top_padding</item>
</style>
<style name="PreferenceButtonStyle" parent="@android:style/Widget.Holo.Light.Button">
<!-- TODO(twellington): Delete btn_default_preferences.xml once the AppCompat theme supports
@@ -72,6 +76,15 @@
<item name="android:textColor">@color/float_label</item>
<item name="android:textSize">14sp</item>
</style>
+ <style name="PreferenceSpinnerItem">
+ <item name="android:textAppearance">@style/PreferenceTextAppearanceMedium</item>
+ </style>
+ <style name="PreferenceSpinnerUnderlineView">
+ <item name="android:layout_width">match_parent</item>
+ <item name="android:layout_height">1dp</item>
+ <item name="android:layout_marginTop">2dp</item>
+ <item name="android:background">@color/input_underline_color</item>
+ </style>
<style name="ThemeWithActionBar" parent="Theme.AppCompat.Light.DarkActionBar">
<item name="android:windowBackground">@android:color/white</item>
« no previous file with comments | « chrome/android/java/res/layout/autofill_profile_editor.xml ('k') | chrome/android/java/res/values-v21/styles.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698