chrome/android/java/res/layout/autofill_profile_editor.xml - Issue 897953002: Underlines for preference spinners and other autofill tweaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/autofill_profile_editor.xml

Issue 897953002: Underlines for preference spinners and other autofill tweaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pref_field_underline_color -> input_underline_color, fix wrapping Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/autofill_credit_card_editor.xml ('k') | chrome/android/java/res/values-v17/styles.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/autofill_profile_editor.xml

diff --git a/chrome/android/java/res/layout/autofill_profile_editor.xml b/chrome/android/java/res/layout/autofill_profile_editor.xml

index 6f06d180caf5f8008b8f5f5eceb89919eb5ee218..209f6372f168ed0765818ccf4b70d0edc3524fe2 100644

--- a/chrome/android/java/res/layout/autofill_profile_editor.xml

+++ b/chrome/android/java/res/layout/autofill_profile_editor.xml

@@ -19,19 +19,29 @@

style="@style/PreferenceScreenLayout"

android:layout_width="match_parent"

android:layout_height="wrap_content"

- android:orientation="vertical">

+ android:orientation="vertical" >

- <TextView

+ <LinearLayout

android:layout_width="match_parent"

- android:layout_height="wrap_content"

- android:focusable="true"

- android:textAppearance="@style/PreferenceFloatLabelTextAppearance"

- android:text="@string/autofill_profile_editor_country" />

- <Spinner

- android:id="@+id/countries"

- android:layout_width="fill_parent"

- android:layout_height="wrap_content" />

+ android:layout_height="match_parent"

+ android:orientation="vertical"

+ android:layout_marginStart="@dimen/pref_autofill_field_horizontal_padding"

+ android:layout_marginEnd="@dimen/pref_autofill_field_horizontal_padding"

+ android:paddingBottom="5dp" >

+ <TextView

+ android:layout_width="match_parent"

+ android:layout_height="wrap_content"

+ android:focusable="true"

+ android:textAppearance="@style/PreferenceFloatLabelTextAppearance"

+ android:text="@string/autofill_profile_editor_country"

+ android:paddingBottom="8dp" />

+ <Spinner

+ android:id="@+id/countries"

+ android:layout_width="fill_parent"

+ android:layout_height="wrap_content" />

+ <View style="@style/PreferenceSpinnerUnderlineView" />

+ </LinearLayout>

<LinearLayout

android:id="@+id/autofill_profile_widget_root"

« no previous file with comments | « chrome/android/java/res/layout/autofill_credit_card_editor.xml ('k') | chrome/android/java/res/values-v17/styles.xml » ('j') | no next file with comments »