Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 897863002: Files.app: Take back disabled DefaultActionDialog/FileManagerBrowserTest. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, nkostylev+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Take back disabled DefaultActionDialog/FileManagerBrowserTest. Previously the test does not wait dialog hiding unintentinally. BUG=452723 TEST=DefaultActionDialog/FileManagerBrowserTest Committed: https://crrev.com/9b213685f06300abf07e3ef2833c837043da026a Cr-Commit-Position: refs/heads/master@{#314531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/tasks.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL, thanks!
5 years, 10 months ago (2015-02-04 07:04:40 UTC) #2
mtomasz
nice, thanks! lgtm
5 years, 10 months ago (2015-02-04 08:50:20 UTC) #3
hirono
thanks!
5 years, 10 months ago (2015-02-04 09:32:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897863002/1
5 years, 10 months ago (2015-02-04 09:32:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 09:35:47 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 09:36:31 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9b213685f06300abf07e3ef2833c837043da026a
Cr-Commit-Position: refs/heads/master@{#314531}

Powered by Google App Engine
This is Rietveld 408576698