Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 897863002: Files.app: Take back disabled DefaultActionDialog/FileManagerBrowserTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/file_manager/integration_tests/file_manager/tasks.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Browser test for basic Chrome OS file manager functionality: 5 // Browser test for basic Chrome OS file manager functionality:
6 // - The file list is updated when a file is added externally to the Downloads 6 // - The file list is updated when a file is added externally to the Downloads
7 // folder. 7 // folder.
8 // - Selecting a file and copy-pasting it with the keyboard copies the file. 8 // - Selecting a file and copy-pasting it with the keyboard copies the file.
9 // - Selecting a file and pressing delete deletes it. 9 // - Selecting a file and pressing delete deletes it.
10 10
(...skipping 1021 matching lines...) Expand 10 before | Expand all | Expand 10 after
1032 #else 1032 #else
1033 #define MAYBE_ExecuteDefaultTaskOnDrive ExecuteDefaultTaskOnDrive 1033 #define MAYBE_ExecuteDefaultTaskOnDrive ExecuteDefaultTaskOnDrive
1034 #endif 1034 #endif
1035 INSTANTIATE_TEST_CASE_P( 1035 INSTANTIATE_TEST_CASE_P(
1036 MAYBE_ExecuteDefaultTaskOnDrive, 1036 MAYBE_ExecuteDefaultTaskOnDrive,
1037 FileManagerBrowserTest, 1037 FileManagerBrowserTest,
1038 ::testing::Values( 1038 ::testing::Values(
1039 TestParameter(NOT_IN_GUEST_MODE, "executeDefaultTaskOnDrive"))); 1039 TestParameter(NOT_IN_GUEST_MODE, "executeDefaultTaskOnDrive")));
1040 1040
1041 // Slow tests are disabled on debug build. http://crbug.com/327719 1041 // Slow tests are disabled on debug build. http://crbug.com/327719
1042 // In addition, this test in particular has become very flaky as of this CL: 1042 #if !defined(NDEBUG)
1043 // https://codereview.chromium.org/838193002/ 1043 #define MAYBE_DefaultActionDialog DISABLED_DefaultActionDialog
1044 // Disable completely until further investigation. See: http://crbug.com/444574. 1044 #else
1045 #define MAYBE_DefaultActionDialog DefaultActionDialog
1046 #endif
1045 WRAPPED_INSTANTIATE_TEST_CASE_P( 1047 WRAPPED_INSTANTIATE_TEST_CASE_P(
1046 DISABLED_DefaultActionDialog, 1048 MAYBE_DefaultActionDialog,
1047 FileManagerBrowserTest, 1049 FileManagerBrowserTest,
1048 ::testing::Values( 1050 ::testing::Values(
1049 TestParameter(NOT_IN_GUEST_MODE, "defaultActionDialogOnDownloads"), 1051 TestParameter(NOT_IN_GUEST_MODE, "defaultActionDialogOnDownloads"),
1050 TestParameter(IN_GUEST_MODE, "defaultActionDialogOnDownloads"), 1052 TestParameter(IN_GUEST_MODE, "defaultActionDialogOnDownloads"),
1051 TestParameter(NOT_IN_GUEST_MODE, "defaultActionDialogOnDrive"))); 1053 TestParameter(NOT_IN_GUEST_MODE, "defaultActionDialogOnDrive")));
1052 1054
1053 // Slow tests are disabled on debug build. http://crbug.com/327719 1055 // Slow tests are disabled on debug build. http://crbug.com/327719
1054 #if !defined(NDEBUG) 1056 #if !defined(NDEBUG)
1055 #define MAYBE_GenericTask DISABLED_GenericTask 1057 #define MAYBE_GenericTask DISABLED_GenericTask
1056 #else 1058 #else
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1517 StartTest(); 1519 StartTest();
1518 } 1520 }
1519 1521
1520 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) { 1522 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) {
1521 set_test_case_name("openSingleVideoOnDrive"); 1523 set_test_case_name("openSingleVideoOnDrive");
1522 StartTest(); 1524 StartTest();
1523 } 1525 }
1524 1526
1525 } // namespace 1527 } // namespace
1526 } // namespace file_manager 1528 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | ui/file_manager/integration_tests/file_manager/tasks.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698