Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 897863002: Files.app: Take back disabled DefaultActionDialog/FileManagerBrowserTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/file_manager/integration_tests/file_manager/tasks.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
index 07062b06968316cdf8502691284dea1e8f7ae058..8c7ae1b5b8ac0c79c9bed5b9d3938a2010887d93 100644
--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
@@ -1039,11 +1039,13 @@ INSTANTIATE_TEST_CASE_P(
TestParameter(NOT_IN_GUEST_MODE, "executeDefaultTaskOnDrive")));
// Slow tests are disabled on debug build. http://crbug.com/327719
-// In addition, this test in particular has become very flaky as of this CL:
-// https://codereview.chromium.org/838193002/
-// Disable completely until further investigation. See: http://crbug.com/444574.
+#if !defined(NDEBUG)
+#define MAYBE_DefaultActionDialog DISABLED_DefaultActionDialog
+#else
+#define MAYBE_DefaultActionDialog DefaultActionDialog
+#endif
WRAPPED_INSTANTIATE_TEST_CASE_P(
- DISABLED_DefaultActionDialog,
+ MAYBE_DefaultActionDialog,
FileManagerBrowserTest,
::testing::Values(
TestParameter(NOT_IN_GUEST_MODE, "defaultActionDialogOnDownloads"),
« no previous file with comments | « no previous file | ui/file_manager/integration_tests/file_manager/tasks.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698