Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 897223002: Revert of Throttle resource message requests during user interaction (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Throttle resource message requests during user interaction (patchset #14 id:300001 of https://codereview.chromium.org/847883002/) Reason for revert: The new DCHECKs for CalledOnValidThread are breaking tests everywhere: https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/6021 Original issue's description: > Throttle resource message requests during user interaction > > Resource message requests can be relatively expensive, particularly in > the induced work on the browser IO thread. Currently, there is no bound > on the rate with which such requests are dispatched from the renderer. > This leads to situations where the browser IO thread is flooded with > requests, potentially causing scroll jank and otherwise undesirable > stalls in the browser pipeline. > > Introduce a ResourceMessageThrottler which intercepts and defers a given > resource message stream, depending on the state of the RendererScheduler. > When the RendererScheduler indicates that high priority work is > imminent/likely, requests will be throttled according to a configurable > dispatch rate. > > Hook this throttling mechanism up to the ResourceDispatcher, limiting > the number of resource message requests/second during user interaction > to 180 (3 per frame at 60 fps) on Android, and 480 on desktop. > > See goo.gl/H42AgQ for more design details. > > BUG=440037, 402136 > > Committed: https://crrev.com/acfb4199abf841a1577c3968579c43b0232a53b7 > Cr-Commit-Position: refs/heads/master@{#314739} TBR=alexclarke@chromium.org,picksi@chromium.org,skyostil@chromium.org,rmcilroy@chromium.org,davidben@chromium.org,jdduke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440037, 402136 Committed: https://crrev.com/0b0860a692e9d327f4f76949d096a7f2b1687c7c Cr-Commit-Position: refs/heads/master@{#314755}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -718 lines) Patch
M content/child/resource_dispatcher.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M content/renderer/scheduler/null_renderer_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/scheduler/null_renderer_scheduler.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler.h View 1 chunk +1 line, -9 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.cc View 8 chunks +15 lines, -26 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl_unittest.cc View 3 chunks +0 lines, -56 lines 0 comments Download
D content/renderer/scheduler/resource_dispatch_throttler.h View 1 chunk +0 lines, -70 lines 0 comments Download
D content/renderer/scheduler/resource_dispatch_throttler.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D content/renderer/scheduler/resource_dispatch_throttler_unittest.cc View 1 chunk +0 lines, -370 lines 0 comments Download
M content/test/fake_renderer_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/fake_renderer_scheduler.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Throttle resource message requests during user interaction
5 years, 10 months ago (2015-02-05 04:39:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897223002/1
5 years, 10 months ago (2015-02-05 04:39:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 04:40:39 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 04:41:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b0860a692e9d327f4f76949d096a7f2b1687c7c
Cr-Commit-Position: refs/heads/master@{#314755}

Powered by Google App Engine
This is Rietveld 408576698