Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 897173005: win: minidump_writeable_test_util from constexpr to enum (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump_test-12
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: minidump_writeable_test_util from constexpr to enum No constexpr on VS2013. :( R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9574e94b3d5d7dc36e0c99aa45fadf3ec8024131

Patch Set 1 #

Total comments: 2

Patch Set 2 : explicit size_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M minidump/test/minidump_writable_test_util.cc View 1 5 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scottmg
5 years, 10 months ago (2015-02-05 06:05:45 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/897173005/diff/1/minidump/test/minidump_writable_test_util.cc File minidump/test/minidump_writable_test_util.cc (right): https://codereview.chromium.org/897173005/diff/1/minidump/test/minidump_writable_test_util.cc#newcode162 minidump/test/minidump_writable_test_util.cc:162: enum { kElementSize = sizeof(MINIDUMP_MEMORY_DESCRIPTOR) }; Can you ...
5 years, 10 months ago (2015-02-05 14:41:05 UTC) #2
scottmg
https://codereview.chromium.org/897173005/diff/1/minidump/test/minidump_writable_test_util.cc File minidump/test/minidump_writable_test_util.cc (right): https://codereview.chromium.org/897173005/diff/1/minidump/test/minidump_writable_test_util.cc#newcode162 minidump/test/minidump_writable_test_util.cc:162: enum { kElementSize = sizeof(MINIDUMP_MEMORY_DESCRIPTOR) }; On 2015/02/05 14:41:05, ...
5 years, 10 months ago (2015-02-05 17:13:00 UTC) #4
scottmg
5 years, 10 months ago (2015-02-05 17:13:17 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9574e94b3d5d7dc36e0c99aa45fadf3ec8024131 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698