Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: minidump/test/minidump_writable_test_util.cc

Issue 897173005: win: minidump_writeable_test_util from constexpr to enum (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_test-12
Patch Set: explicit size_t Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/test/minidump_writable_test_util.cc
diff --git a/minidump/test/minidump_writable_test_util.cc b/minidump/test/minidump_writable_test_util.cc
index b2ea242a3859af6957ee109eba8682f5bd95447a..37b2f04831eff107af5e856763c318bf7c928cfb 100644
--- a/minidump/test/minidump_writable_test_util.cc
+++ b/minidump/test/minidump_writable_test_util.cc
@@ -159,7 +159,7 @@ namespace {
struct MinidumpMemoryListTraits {
using ListType = MINIDUMP_MEMORY_LIST;
- static constexpr size_t kElementSize = sizeof(MINIDUMP_MEMORY_DESCRIPTOR);
+ enum : size_t { kElementSize = sizeof(MINIDUMP_MEMORY_DESCRIPTOR) };
static size_t ElementCount(const ListType* list) {
return list->NumberOfMemoryRanges;
}
@@ -167,7 +167,7 @@ struct MinidumpMemoryListTraits {
struct MinidumpModuleListTraits {
using ListType = MINIDUMP_MODULE_LIST;
- static constexpr size_t kElementSize = sizeof(MINIDUMP_MODULE);
+ enum : size_t { kElementSize = sizeof(MINIDUMP_MODULE) };
static size_t ElementCount(const ListType* list) {
return list->NumberOfModules;
}
@@ -175,7 +175,7 @@ struct MinidumpModuleListTraits {
struct MinidumpThreadListTraits {
using ListType = MINIDUMP_THREAD_LIST;
- static constexpr size_t kElementSize = sizeof(MINIDUMP_THREAD);
+ enum : size_t { kElementSize = sizeof(MINIDUMP_THREAD) };
static size_t ElementCount(const ListType* list) {
return list->NumberOfThreads;
}
@@ -183,7 +183,7 @@ struct MinidumpThreadListTraits {
struct MinidumpLocationDescriptorListTraits {
using ListType = MinidumpLocationDescriptorList;
- static constexpr size_t kElementSize = sizeof(MINIDUMP_LOCATION_DESCRIPTOR);
+ enum : size_t { kElementSize = sizeof(MINIDUMP_LOCATION_DESCRIPTOR) };
static size_t ElementCount(const ListType* list) {
return list->count;
}
@@ -191,8 +191,7 @@ struct MinidumpLocationDescriptorListTraits {
struct MinidumpSimpleStringDictionaryListTraits {
using ListType = MinidumpSimpleStringDictionary;
- static constexpr size_t kElementSize =
- sizeof(MinidumpSimpleStringDictionaryEntry);
+ enum : size_t { kElementSize = sizeof(MinidumpSimpleStringDictionaryEntry) };
static size_t ElementCount(const ListType* list) {
return list->count;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698