win: minidump_writeable_test_util from constexpr to enum

minidump/test/minidump_writable_test_util.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 141 matching lines @@
     return nullptr;
   }
 
   return header;
 }
 
 namespace {
 
 struct MinidumpMemoryListTraits {
   using ListType = MINIDUMP_MEMORY_LIST;
-  static constexpr size_t kElementSize = sizeof(MINIDUMP_MEMORY_DESCRIPTOR);
+  enum { kElementSize = sizeof(MINIDUMP_MEMORY_DESCRIPTOR) };

[Mark Mentovai, 2015/02/05 14:41:05]

Can you type these with enum : size_t?

[scottmg, 2015/02/05 17:13:00]

Done.

   static size_t ElementCount(const ListType* list) {
     return list->NumberOfMemoryRanges;
   }
 };
 
 struct MinidumpModuleListTraits {
   using ListType = MINIDUMP_MODULE_LIST;
-  static constexpr size_t kElementSize = sizeof(MINIDUMP_MODULE);
+  enum { kElementSize = sizeof(MINIDUMP_MODULE) };
   static size_t ElementCount(const ListType* list) {
     return list->NumberOfModules;
   }
 };
 
 struct MinidumpThreadListTraits {
   using ListType = MINIDUMP_THREAD_LIST;
-  static constexpr size_t kElementSize = sizeof(MINIDUMP_THREAD);
+  enum { kElementSize = sizeof(MINIDUMP_THREAD) };
   static size_t ElementCount(const ListType* list) {
     return list->NumberOfThreads;
   }
 };
 
 struct MinidumpLocationDescriptorListTraits {
   using ListType = MinidumpLocationDescriptorList;
-  static constexpr size_t kElementSize = sizeof(MINIDUMP_LOCATION_DESCRIPTOR);
+  enum { kElementSize = sizeof(MINIDUMP_LOCATION_DESCRIPTOR) };
   static size_t ElementCount(const ListType* list) {
     return list->count;
   }
 };
 
 struct MinidumpSimpleStringDictionaryListTraits {
   using ListType = MinidumpSimpleStringDictionary;
-  static constexpr size_t kElementSize =
-      sizeof(MinidumpSimpleStringDictionaryEntry);
+  enum { kElementSize = sizeof(MinidumpSimpleStringDictionaryEntry) };
   static size_t ElementCount(const ListType* list) {
     return list->count;
   }
 };
 
 template <typename T>
 const typename T::ListType* MinidumpListAtLocationDescriptor(
     const std::string& file_contents,
     const MINIDUMP_LOCATION_DESCRIPTOR& location) {
   const typename T::ListType* list =
@@ skipping 114 matching lines @@
 size_t TestUInt32MinidumpWritable::SizeOfObject() {
   return sizeof(value_);
 }
 
 bool TestUInt32MinidumpWritable::WriteObject(FileWriterInterface* file_writer) {
   return file_writer->Write(&value_, sizeof(value_));
 }
 
 }  // namespace test
 }  // namespace crashpad