[WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (2/3)

ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (2/3)

This series of CLs changes a call sequence of unregister API.
(See the 1st CL for more details)

This 2nd CL implements WebServiceWorkerRegistrationImpl::unregister.

CL dependency:
 (1) Blink: https://codereview.chromium.org/897573002/
 (2) Chromium: THIS PATCH
 (3) Blink: https://codereview.chromium.org/896433005/


BUG=452910
TEST=compile

[nhiroki, 2015-02-03 05:30:39]

nhiroki@chromium.org changed reviewers:
+ kinuko@chromium.org

[nhiroki, 2015-02-03 05:30:49]

PTAL, thanks!

[kinuko, 2015-02-03 07:58:01]

lgtm

[kinuko, 2015-02-03 07:58:03]

lgtm

[nhiroki, 2015-02-03 07:59:23]

nhiroki@chromium.org changed reviewers:
+ mkwst@chromium.org

[kinuko, 2015-02-03 08:02:11]

https://codereview.chromium.org/896533004/diff/1/content/child/service_worker...
File content/child/service_worker/web_service_worker_registration_impl.cc
(right):

https://codereview.chromium.org/896533004/diff/1/content/child/service_worker...
content/child/service_worker/web_service_worker_registration_impl.cc:122:
dispatcher->UnregisterServiceWorker(provider_id_, scope(), callbacks);
If a registration outlives the document (and its provider) this will fail (and
causes crash)?

[nhiroki, 2015-02-03 08:19:25]

mkwst@, let me remove you from the reviewer list until the issue kinuko@
mentioned gets fixed. Sorry for spamming.

[nhiroki, 2015-02-03 08:19:40]

nhiroki@chromium.org changed reviewers:
- mkwst@chromium.org

[nhiroki, 2015-02-03 12:59:37]

Thank you for reviewing. As per review comments, I'll drop this series of CLs
and create new ones...

https://codereview.chromium.org/896533004/diff/1/content/child/service_worker...
File content/child/service_worker/web_service_worker_registration_impl.cc
(right):

https://codereview.chromium.org/896533004/diff/1/content/child/service_worker...
content/child/service_worker/web_service_worker_registration_impl.cc:122:
dispatcher->UnregisterServiceWorker(provider_id_, scope(), callbacks);
On 2015/02/03 08:02:11, kinuko wrote:
> If a registration outlives the document (and its provider) this will fail (and
> causes crash)?

Good point. I understand that WebSWRegistration must not depend on the original
provider who created it. I'm now planning to make WebSWProvider available on
SWGlobalScope instead of this series of CLs...