content/browser/service_worker/service_worker_dispatcher_host.cc - Issue 896533004: [WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 896533004: [WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/child/service_worker/service_worker_dispatcher.h » ('j') | content/child/service_worker/web_service_worker_registration_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc

index aa954ee1dd0f34a158417c8675def8e9efc585cb..a747d667512366e6fb2fc64a51f935ed52487c68 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc

@@ -637,7 +637,7 @@ void ServiceWorkerDispatcherHost::RegistrationComplete(

provider_host->AsWeakPtr(), registration, &info, &attrs);

Send(new ServiceWorkerMsg_ServiceWorkerRegistered(

- thread_id, request_id, info, attrs));

+ thread_id, request_id, provider_id, info, attrs));

TRACE_EVENT_ASYNC_END1("ServiceWorker",

"ServiceWorkerDispatcherHost::RegisterServiceWorker",

request_id,

@@ -884,7 +884,7 @@ void ServiceWorkerDispatcherHost::GetRegistrationComplete(

}

Send(new ServiceWorkerMsg_DidGetRegistration(

- thread_id, request_id, info, attrs));

+ thread_id, request_id, provider_id, info, attrs));

}

void ServiceWorkerDispatcherHost::SendRegistrationError(