content/child/service_worker/web_service_worker_registration_impl.h - Issue 896533004: [WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.h

Issue 896533004: [WONT COMMIT] ServiceWorker: Move unregister function from WebSWProvider to WebSWRegistration (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/web_service_worker_provider_impl.cc ('k') | content/child/service_worker/web_service_worker_registration_impl.cc » ('j') | content/child/service_worker/web_service_worker_registration_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_registration_impl.h

diff --git a/content/child/service_worker/web_service_worker_registration_impl.h b/content/child/service_worker/web_service_worker_registration_impl.h

index 52ee1029ddf10ce6c902d9cec95bc5686b899466..801ee53c70d8d2a106f3345a0c1f5d4ba5543419 100644

--- a/content/child/service_worker/web_service_worker_registration_impl.h

+++ b/content/child/service_worker/web_service_worker_registration_impl.h

@@ -24,7 +24,11 @@ struct ServiceWorkerObjectInfo;

class WebServiceWorkerRegistrationImpl

: NON_EXPORTED_BASE(public blink::WebServiceWorkerRegistration) {

public:

- explicit WebServiceWorkerRegistrationImpl(

+ using UnregisterCallbacks =

+ blink::WebServiceWorkerRegistration::UnregisterCallbacks;

+ WebServiceWorkerRegistrationImpl(

+ int provider_id,

scoped_ptr<ServiceWorkerRegistrationHandleReference> handle_ref);

virtual ~WebServiceWorkerRegistrationImpl();

@@ -38,6 +42,7 @@ class WebServiceWorkerRegistrationImpl

virtual void setProxy(blink::WebServiceWorkerRegistrationProxy* proxy);

virtual blink::WebServiceWorkerRegistrationProxy* proxy();

virtual blink::WebURL scope() const;

+ virtual void unregister(UnregisterCallbacks*);

int64 registration_id() const;

@@ -59,6 +64,7 @@ class WebServiceWorkerRegistrationImpl

void RunQueuedTasks();

void ClearQueuedTasks();

+ const int provider_id_;

scoped_ptr<ServiceWorkerRegistrationHandleReference> handle_ref_;

blink::WebServiceWorkerRegistrationProxy* proxy_;