Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2838)

Unified Diff: chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc

Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc
diff --git a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc
index 088b1dddb43d30c08e7b989b0373530083954019..3852d2556ba10ac1ba81c62de4baae0c918dfcc9 100644
--- a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc
+++ b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_aura.cc
@@ -22,6 +22,9 @@ NativeTabContentsContainerAura::NativeTabContentsContainerAura(
TabContentsContainer* container)
: container_(container) {
set_id(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW);
+ // We need to be focusable when our contents is not a view hierarchy, as
+ // clicking on the contents needs to focus us.
+ set_focusable(container_->tab_contents() != NULL);
}
NativeTabContentsContainerAura::~NativeTabContentsContainerAura() {
@@ -94,12 +97,6 @@ bool NativeTabContentsContainerAura::SkipDefaultKeyEventProcessing(
!container_->tab_contents()->is_crashed();
}
-bool NativeTabContentsContainerAura::IsFocusable() const {
- // We need to be focusable when our contents is not a view hierarchy, as
- // clicking on the contents needs to focus us.
- return container_->tab_contents() != NULL;
Ben Goodger (Google) 2011/12/15 21:21:41 But can the TabContents become NULL at some point
-}
-
void NativeTabContentsContainerAura::OnFocus() {
if (container_->tab_contents())
container_->tab_contents()->Focus();

Powered by Google App Engine
This is Rietveld 408576698