Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 139b5d9abac1dac9e056b0eecdb89153177ccea1..d8000ec8be46cfba04a915e9baebf28f4f192def 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -71,12 +71,6 @@ class AutocompleteTextfield : public views::Textfield {
return omnibox_view_->HandleKeyReleaseEvent(event);
}
- virtual bool IsFocusable() const OVERRIDE {
- // Bypass Textfield::IsFocusable. The omnibox in popup window requires
- // focus in order for text selection to work.
- return views::View::IsFocusable();
Ben Goodger (Google) 2011/12/15 21:21:41 Is this comment no longer valid?
- }
-
virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE {
return omnibox_view_->HandleMousePressEvent(event);
}

Powered by Google App Engine
This is Rietveld 408576698