Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc

Issue 8964001: views: Convert IsFocusable() to just focusable() since it's just a simple accessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc
diff --git a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc
index e6e1dc75f8d3ae72bbaa734d14ea815bd44cd39e..ccb3f8d661e658d6c3c56528162b66f08866aaf4 100644
--- a/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc
+++ b/chrome/browser/ui/views/tab_contents/native_tab_contents_container_gtk.cc
@@ -21,6 +21,9 @@ NativeTabContentsContainerGtk::NativeTabContentsContainerGtk(
: container_(container),
focus_callback_id_(0) {
set_id(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW);
+ // We need to be focusable when our contents is not a view hierarchy, as
+ // clicking on the contents needs to focus us.
+ set_focusable(container_->tab_contents() != NULL);
}
NativeTabContentsContainerGtk::~NativeTabContentsContainerGtk() {
@@ -97,12 +100,6 @@ views::FocusTraversable* NativeTabContentsContainerGtk::GetFocusTraversable() {
return NULL;
}
-bool NativeTabContentsContainerGtk::IsFocusable() const {
- // We need to be focusable when our contents is not a view hierarchy, as
- // clicking on the contents needs to focus us.
Ben Goodger (Google) 2011/12/15 21:21:41 Same question as the other file.
- return container_->tab_contents() != NULL;
-}
-
void NativeTabContentsContainerGtk::OnFocus() {
if (container_->tab_contents())
container_->tab_contents()->Focus();

Powered by Google App Engine
This is Rietveld 408576698