Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 896023003: Prevent base::CheckedNumeric from leaking outside of pdfium. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prevent base::CheckedNumeric from leaking outside of pdfium. Headers in /include directories should be free of implementation details from third_party. Put the types into a new header outside of /include. Requires https://codereview.chromium.org/902443003/ before a version containing this patch is rolled into chromium. R=jam@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/62120b79bbaca7430a8fc7ba0846b0a84f40542d

Patch Set 1 #

Patch Set 2 : Add name of new .h to build files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -9 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fxcrt/fx_system.h View 1 chunk +0 lines, -5 lines 0 comments Download
M core/src/fdrm/crypto/fx_crypt.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fxcrt/extension.h View 1 chunk +2 lines, -0 lines 0 comments Download
A core/src/fxcrt/fx_safe_types.h View 1 chunk +17 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M pdfium.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
John, please review. I happened to notice this while putting together the unrelated ill-fated mini_chromium ...
5 years, 10 months ago (2015-02-03 23:47:03 UTC) #2
jam
lgtm
5 years, 10 months ago (2015-02-04 16:37:41 UTC) #3
Tom Sepez
5 years, 10 months ago (2015-02-04 18:37:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
62120b79bbaca7430a8fc7ba0846b0a84f40542d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698