core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp - Issue 896023003: Prevent base::CheckedNumeric from leaking outside of pdfium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp

Issue 896023003: Prevent base::CheckedNumeric from leaking outside of pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Add name of new .h to build files. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp

index 3ceb0f7e8b4de2cb84357b43d7d40182fc5aaada..7d727f37fba5caf63677e1a2919dc4a74ee242ce 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp

@@ -4,11 +4,14 @@

+#include <limits.h>

#include "../../../include/fpdfapi/fpdf_page.h"

#include "../../../include/fpdfapi/fpdf_module.h"

+#include "../../../src/fxcrt/fx_safe_types.h"

#include "../../../third_party/numerics/safe_conversions_impl.h"

#include "pageint.h"

-#include <limits.h>

class CPDF_PSEngine;

typedef enum {PSOP_ADD, PSOP_SUB, PSOP_MUL, PSOP_DIV, PSOP_IDIV, PSOP_MOD,

PSOP_NEG, PSOP_ABS, PSOP_CEILING, PSOP_FLOOR, PSOP_ROUND, PSOP_TRUNCATE,

« no previous file with comments | « core/src/fdrm/crypto/fx_crypt.cpp ('k') | core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp » ('j') | no next file with comments »