core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp - Issue 896023003: Prevent base::CheckedNumeric from leaking outside of pdfium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

Issue 896023003: Prevent base::CheckedNumeric from leaking outside of pdfium. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Add name of new .h to build files. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

index 1637655e68d9f44642a9c478ce37521371158bf0..f938628f55f9df743e030cbda2e2e05f5e1fe87c 100644

--- a/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp

@@ -9,9 +9,9 @@

#include "../../../include/fpdfapi/fpdf_module.h"

#include "../../../include/fpdfapi/fpdf_render.h"

#include "../../../include/fpdfapi/fpdf_pageobj.h"

+#include "../../../src/fxcrt/fx_safe_types.h"

#include "../fpdf_page/pageint.h"

#include "render_int.h"

-#include "../../../../third_party/numerics/safe_math.h"

static unsigned int _GetBits8(FX_LPCBYTE pData, int bitpos, int nbits)

{

« no previous file with comments | « core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp ('k') | core/src/fpdfdoc/doc_link.cpp » ('j') | no next file with comments »