Files.app: Split the startRequests method of metadata models into createRequests and startRequests.

Files.app: Split the startRequests method of metadata models into createRequests and startRequests.

Currently the startRequests method of metadata models has a responsibility to
create requests as well as to mark the cache as loading.

In the following patch, we need to apply the requests that are generated by
another cache set. Thus the method should be split into two methods (one is for
creating requests and another is for marking cache as loading).

BUG=410766
TEST=FileManagerJsTest.MetadataCacheSet,FileManagerJsTest.MetadataCacheItem
R=yawano@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/322fd48b369d42875015093e0b9a00df08eee58b

[hirono, 2015-02-02 23:40:52]

hirono@chromium.org changed reviewers:
+ yawano@chromium.org

[hirono, 2015-02-02 23:40:52]

PTAL. Thanks!

[yawano, 2015-02-03 02:03:22]

Thank you!

1 very small nit: Typo in description, anoother -> another.

https://codereview.chromium.org/895783003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js
(right):

https://codereview.chromium.org/895783003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js:19:
MetadataCacheItem.prototype.createRequests = function(names) {
nit: Please provide doc comment for public methods.

https://codereview.chromium.org/895783003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js:35: *
Marks invalidated properies as loading and returns property names that are
Please fix doc comment. It seems different from what this code actually does.

[hirono, 2015-02-03 03:27:25]

Thanks!

https://codereview.chromium.org/895783003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js
(right):

https://codereview.chromium.org/895783003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js:19:
MetadataCacheItem.prototype.createRequests = function(names) {
On 2015/02/03 02:03:22, yawano wrote:
> nit: Please provide doc comment for public methods.

Done.

https://codereview.chromium.org/895783003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item.js:35: *
Marks invalidated properies as loading and returns property names that are
On 2015/02/03 02:03:22, yawano wrote:
> Please fix doc comment. It seems different from what this code actually does.

Done.

[yawano, 2015-02-03 03:39:32]

The CQ bit was checked by yawano@chromium.org

[yawano, 2015-02-03 03:39:58]

The CQ bit was unchecked by yawano@chromium.org

[yawano, 2015-02-03 03:41:38]

lgtm. Thank you!

[hirono, 2015-02-03 03:45:59]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2015-02-03 03:47:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895783003/40001

[commit-bot: I haz the power, 2015-02-03 05:12:25]

Patchset 3 (id:??) landed as
https://crrev.com/322fd48b369d42875015093e0b9a00df08eee58b
Cr-Commit-Position: refs/heads/master@{#314270}

[hirono, 2015-02-03 05:12:37]

Committed patchset #3 (id:40001) manually as
322fd48b369d42875015093e0b9a00df08eee58b (presubmit successful).