Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js

Issue 895783003: Files.app: Split the startRequests method of metadata models into createRequests and startRequests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
index d1815a8c7f4bb401aa68a0974c1cc74137b084fe..279ab9fee4d2e1a4e300ef2e4dabaea2e2e4b27e 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.js
@@ -4,10 +4,11 @@
function testMetadataCacheItemBasic() {
var item = new MetadataCacheItem();
- var loadRequested = item.startRequests(1, ['propertyA']);
+ var loadRequested = item.createRequests(['propertyA']);
assertEquals(1, loadRequested.length);
assertEquals('propertyA', loadRequested[0]);
+ item.startRequests(1, loadRequested);
assertTrue(item.storeProperties(1, {propertyA: 'value'}));
var result = item.get(['propertyA']);
@@ -17,9 +18,10 @@ function testMetadataCacheItemBasic() {
function testMetadataCacheItemAvoidDoubleLoad() {
var item = new MetadataCacheItem();
item.startRequests(1, ['propertyA']);
- var loadRequested = item.startRequests(2, ['propertyA']);
+ var loadRequested = item.createRequests(['propertyA']);
assertEquals(0, loadRequested.length);
+ item.startRequests(2, loadRequested);
assertTrue(item.storeProperties(1, {propertyA: 'value'}));
var result = item.get(['propertyA']);
@@ -28,18 +30,18 @@ function testMetadataCacheItemAvoidDoubleLoad() {
function testMetadataCacheItemInvalidate() {
var item = new MetadataCacheItem();
- item.startRequests(1, ['propertyA']);
+ item.startRequests(1, item.createRequests(['propertyA']));
item.invalidate(2);
assertFalse(item.storeProperties(1, {propertyA: 'value'}));
- var loadRequested = item.startRequests(3, ['propertyA']);
+ var loadRequested = item.createRequests(['propertyA']);
assertEquals(1, loadRequested.length);
}
function testMetadataCacheItemStoreInReverseOrder() {
var item = new MetadataCacheItem();
- item.startRequests(1, ['propertyA']);
- item.startRequests(2, ['propertyA']);
+ item.startRequests(1, item.createRequests(['propertyA']));
+ item.startRequests(2, item.createRequests(['propertyA']));
assertTrue(item.storeProperties(2, {propertyA: 'value2'}));
assertFalse(item.storeProperties(1, {propertyA: 'value1'}));

Powered by Google App Engine
This is Rietveld 408576698