Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js

Issue 895783003: Files.app: Split the startRequests method of metadata models into createRequests and startRequests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js
index 9f3f37f9b318ff013b430987301703070859807d..6d3b8a43f559c0de4125a4a806aa385abc4faf25 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js
@@ -12,7 +12,7 @@ var entryB = {
function testMetadataCacheSetBasic() {
var set = new MetadataCacheSet(new MetadataCacheSetStorageForObject({}));
- var loadRequested = set.startRequests(1, [entryA, entryB], ['property']);
+ var loadRequested = set.createRequests([entryA, entryB], ['property']);
assertEquals(2, loadRequested.length);
assertEquals(entryA, loadRequested[0].entry);
assertEquals(1, loadRequested[0].names.length);
@@ -21,6 +21,7 @@ function testMetadataCacheSetBasic() {
assertEquals(1, loadRequested[1].names.length);
assertEquals('property', loadRequested[1].names[0]);
+ set.startRequests(1, loadRequested);
assertTrue(set.storeProperties(
1, [entryA, entryB], [{property: 'valueA'}, {property: 'valueB'}]));
@@ -32,7 +33,7 @@ function testMetadataCacheSetBasic() {
function testMetadataCacheSetStorePartial() {
var set = new MetadataCacheSet(new MetadataCacheSetStorageForObject({}));
- set.startRequests(1, [entryA, entryB], ['property']);
+ set.startRequests(1, set.createRequests([entryA, entryB], ['property']));
assertTrue(set.storeProperties(
1, [entryA], [{property: 'valueA'}]));
@@ -51,11 +52,11 @@ function testMetadataCacheSetStorePartial() {
function testMetadataCacheSetCachePartial() {
var set = new MetadataCacheSet(new MetadataCacheSetStorageForObject({}));
- set.startRequests(1, [entryA], ['property']);
+ set.startRequests(1, set.createRequests([entryA], ['property']));
set.storeProperties(1, [entryA], [{property: 'valueA'}]);
// entryA has already been cached.
- var loadRequested = set.startRequests(2, [entryA, entryB], ['property']);
+ var loadRequested = set.createRequests([entryA, entryB], ['property']);
assertEquals(1, loadRequested.length);
assertEquals(entryB, loadRequested[0].entry);
assertEquals(1, loadRequested[0].names.length);
@@ -64,7 +65,7 @@ function testMetadataCacheSetCachePartial() {
function testMetadataCacheSetInvalidatePartial() {
var set = new MetadataCacheSet(new MetadataCacheSetStorageForObject({}));
- set.startRequests(1, [entryA, entryB], ['property']);
+ set.startRequests(1, set.createRequests([entryA, entryB], ['property']));
set.invalidate(2, [entryA]);
assertTrue(set.storeProperties(
@@ -75,7 +76,7 @@ function testMetadataCacheSetInvalidatePartial() {
assertEquals(null, results[0].property);
assertEquals('valueB', results[1].property);
- var loadRequested = set.startRequests(3, [entryA, entryB], ['property']);
+ var loadRequested = set.createRequests([entryA, entryB], ['property']);
assertEquals(1, loadRequested.length);
assertEquals(entryA, loadRequested[0].entry);
assertEquals(1, loadRequested[0].names.length);
« no previous file with comments | « ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698