Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 895443002: ui: Fix more GYP TODOs. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews, Dirk Pranke, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Fix more GYP TODOs. There aren't many TODO(GYP) remaning and these are the ones I can do since I don't have a Mac yet. Tested with the following command line: $ gn gen --args='os="android" cpu_arch="arm"' out_gn_android/Debug BUG=None TEST=see above R=brettw@chromium.org Committed: https://crrev.com/7a17894f92a4be06ab512d0c906162fc8a2625fc Cr-Commit-Position: refs/heads/master@{#314182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M ui/gfx/BUILD.gn View 2 chunks +3 lines, -8 lines 0 comments Download
M ui/shell_dialogs/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
5 years, 10 months ago (2015-02-02 01:15:19 UTC) #1
sky
LGTM
5 years, 10 months ago (2015-02-02 17:04:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895443002/1
5 years, 10 months ago (2015-02-02 20:27:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-02 20:31:59 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 20:32:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a17894f92a4be06ab512d0c906162fc8a2625fc
Cr-Commit-Position: refs/heads/master@{#314182}

Powered by Google App Engine
This is Rietveld 408576698