Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: ui/gfx/BUILD.gn

Issue 895443002: ui: Fix more GYP TODOs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/shell_dialogs/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/BUILD.gn
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn
index 09cab868fe5e190b23990da091323f39b8e508f7..e3fa4f87f5af967f5a64abe7b76987c77158c30a 100644
--- a/ui/gfx/BUILD.gn
+++ b/ui/gfx/BUILD.gn
@@ -286,10 +286,9 @@ component("gfx") {
sources -= [ "path.cc" ]
}
- # TODO(GYP) re-enable when base_java exists.
- #if (!is_android_webview_build) {
- # deps += [ "//base:base_java" ]
- #}
+ if (!is_android_webview_build) {
+ deps += [ "//base:base_java" ]
+ }
if (!is_debug) {
configs -= [ "//build/config/compiler:optimize" ]
@@ -514,10 +513,6 @@ test("gfx_unittests") {
# does not compile display_observer.cc
"display_change_notifier_unittest.cc",
]
-
- deps += [
- #'../../testing/android/native_test.gyp:native_test_native_code', TODO(GYP)
- ]
}
if (is_android || is_ios) {
« no previous file with comments | « no previous file | ui/shell_dialogs/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698