Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: ui/gfx/BUILD.gn

Issue 895443002: ui: Fix more GYP TODOs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/shell_dialogs/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 if (is_android) { 8 if (is_android) {
9 import("//build/config/android/config.gni") 9 import("//build/config/android/config.gni")
10 import("//build/config/android/rules.gni") 10 import("//build/config/android/rules.gni")
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 "canvas_skia.cc", 279 "canvas_skia.cc",
280 "selection_model.cc", 280 "selection_model.cc",
281 ] 281 ]
282 282
283 if (use_aura) { 283 if (use_aura) {
284 sources -= [ "screen_android.cc" ] 284 sources -= [ "screen_android.cc" ]
285 } else { 285 } else {
286 sources -= [ "path.cc" ] 286 sources -= [ "path.cc" ]
287 } 287 }
288 288
289 # TODO(GYP) re-enable when base_java exists. 289 if (!is_android_webview_build) {
290 #if (!is_android_webview_build) { 290 deps += [ "//base:base_java" ]
291 # deps += [ "//base:base_java" ] 291 }
292 #}
293 292
294 if (!is_debug) { 293 if (!is_debug) {
295 configs -= [ "//build/config/compiler:optimize" ] 294 configs -= [ "//build/config/compiler:optimize" ]
296 configs += [ "//build/config/compiler:optimize_max" ] 295 configs += [ "//build/config/compiler:optimize_max" ]
297 } 296 }
298 297
299 deps += [ ":gfx_jni_headers" ] 298 deps += [ ":gfx_jni_headers" ]
300 libs = [ 299 libs = [
301 "android", 300 "android",
302 "jnigraphics", 301 "jnigraphics",
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 "text_elider_unittest.cc", 506 "text_elider_unittest.cc",
508 ] 507 ]
509 } 508 }
510 509
511 if (is_android) { 510 if (is_android) {
512 sources -= [ 511 sources -= [
513 # Do not run display_change_notifier_unittest.cc on Android because it 512 # Do not run display_change_notifier_unittest.cc on Android because it
514 # does not compile display_observer.cc 513 # does not compile display_observer.cc
515 "display_change_notifier_unittest.cc", 514 "display_change_notifier_unittest.cc",
516 ] 515 ]
517
518 deps += [
519 #'../../testing/android/native_test.gyp:native_test_native_code', TODO(GYP )
520 ]
521 } 516 }
522 517
523 if (is_android || is_ios) { 518 if (is_android || is_ios) {
524 sources -= [ "render_text_unittest.cc" ] 519 sources -= [ "render_text_unittest.cc" ]
525 } 520 }
526 521
527 if (use_aura) { 522 if (use_aura) {
528 sources -= [ "screen_unittest.cc" ] 523 sources -= [ "screen_unittest.cc" ]
529 } 524 }
530 525
(...skipping 27 matching lines...) Expand all
558 if (is_android) { 553 if (is_android) {
559 generate_jni("gfx_jni_headers") { 554 generate_jni("gfx_jni_headers") {
560 sources = [ 555 sources = [
561 "../android/java/src/org/chromium/ui/gfx/BitmapHelper.java", 556 "../android/java/src/org/chromium/ui/gfx/BitmapHelper.java",
562 "../android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java", 557 "../android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java",
563 "../android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java", 558 "../android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java",
564 ] 559 ]
565 jni_package = "gfx" 560 jni_package = "gfx"
566 } 561 }
567 } 562 }
OLDNEW
« no previous file with comments | « no previous file | ui/shell_dialogs/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698