Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 894083003: add SkAnimTimer, SPACE = pause/resume, ESP = stop (Closed)

Created:
5 years, 10 months ago by reed1
Modified:
5 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add SkAnimTimer, SPACE = pause/resume, ESP = stop BUG=skia: Committed: https://skia.googlesource.com/skia/+/76113a9b7716748c70ea0ecf7aacbabe4cce5009

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -147 lines) Patch
A gm/SkAnimTimer.h View 1 chunk +139 lines, -0 lines 1 comment Download
M gm/addarc.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M gm/gm.h View 3 chunks +4 lines, -2 lines 0 comments Download
M gm/gm.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/GMSampleView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SampleAnimBlur.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M samplecode/SampleApp.h View 1 chunk +0 lines, -3 lines 0 comments Download
M samplecode/SampleApp.cpp View 11 chunks +18 lines, -73 lines 0 comments Download
M samplecode/SampleArc.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M samplecode/SampleBitmapRect.cpp View 8 chunks +41 lines, -29 lines 0 comments Download
M samplecode/SampleCamera.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M samplecode/SampleCode.h View 6 chunks +4 lines, -14 lines 0 comments Download
M samplecode/SampleDegenerateTwoPtRadials.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M samplecode/SampleHT.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M samplecode/SampleHairline.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M samplecode/SamplePathEffects.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reed1
5 years, 10 months ago (2015-02-02 19:52:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/894083003/1
5 years, 10 months ago (2015-02-02 20:39:41 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-02 20:39:42 UTC) #5
bsalomon
lgtm https://codereview.chromium.org/894083003/diff/1/gm/SkAnimTimer.h File gm/SkAnimTimer.h (right): https://codereview.chromium.org/894083003/diff/1/gm/SkAnimTimer.h#newcode129 gm/SkAnimTimer.h:129: } break; minor, thought we put the break ...
5 years, 10 months ago (2015-02-02 20:54:25 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 20:55:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/76113a9b7716748c70ea0ecf7aacbabe4cce5009

Powered by Google App Engine
This is Rietveld 408576698