Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 893303003: Update {virtual,override,final} to follow C++11 style. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
Cait (Slow)
CC:
aandrey+blink_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kalyank, paulirish+reviews_chromium.org, pfeldman, sadrul, vsevik, yurys, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=caitkp@chromium.org Committed: https://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb Cr-Commit-Position: refs/heads/master@{#314677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -220 lines) Patch
M components/crash/browser/crash_dump_manager_android.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/url_request_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/url_request_context_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/url_request_context_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/wrapped_channel_upload_element_reader.h View 1 chunk +8 lines, -8 lines 0 comments Download
M components/devtools_bridge/android/session_dependency_factory_android.h View 1 chunk +4 lines, -5 lines 0 comments Download
M components/devtools_bridge/android/session_dependency_factory_android.cc View 3 chunks +11 lines, -13 lines 0 comments Download
M components/devtools_bridge/session_dependency_factory.cc View 19 chunks +40 lines, -53 lines 0 comments Download
M components/devtools_bridge/socket_tunnel_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/distilled_page_prefs_android.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.h View 2 chunks +27 lines, -31 lines 0 comments Download
M components/history/core/browser/android/android_urls_sql_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/history/core/browser/android/favicon_sql_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/history/core/browser/android/urls_sql_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/history/core/browser/android/visit_sql_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/invalidation/invalidation_service_android.h View 1 chunk +11 lines, -13 lines 0 comments Download
M components/invalidation/invalidation_service_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/navigation_interception/intercept_navigation_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_provider_android.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/policy_provider_android_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/web_contents_delegate_android/color_chooser_android.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.h View 3 chunks +45 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 10 months ago (2015-02-04 00:49:34 UTC) #1
Cait (Slow)
lgtm
5 years, 10 months ago (2015-02-04 22:14:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/893303003/1
5 years, 10 months ago (2015-02-04 22:17:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 23:34:40 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 23:35:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e27b1ef23206ea3352b4623184b3533b2bac4dcb
Cr-Commit-Position: refs/heads/master@{#314677}

Powered by Google App Engine
This is Rietveld 408576698