Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: components/devtools_bridge/android/session_dependency_factory_android.cc

Issue 893303003: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/devtools_bridge/android/session_dependency_factory_android.cc
diff --git a/components/devtools_bridge/android/session_dependency_factory_android.cc b/components/devtools_bridge/android/session_dependency_factory_android.cc
index 7f3ea568376c5a5011f0bd981ae1d7b4c66477a3..50c81c5c78f776445ac73183fdea3a9cade9c5f8 100644
--- a/components/devtools_bridge/android/session_dependency_factory_android.cc
+++ b/components/devtools_bridge/android/session_dependency_factory_android.cc
@@ -39,15 +39,15 @@ class PeerConnectionDelegateImpl
connected_ = false;
}
- virtual void OnIceConnectionChange(bool connected) override {
+ void OnIceConnectionChange(bool connected) override {
JNIEnv* env = AttachCurrentThread();
Java_SessionDependencyFactoryNative_notifyIceConnectionChange(
env, java_object_.obj(), connected);
}
- virtual void OnIceCandidate(
- const std::string& sdp_mid, int sdp_mline_index, const std::string& sdp)
- override {
+ void OnIceCandidate(const std::string& sdp_mid,
+ int sdp_mline_index,
+ const std::string& sdp) override {
JNIEnv* env = AttachCurrentThread();
Java_SessionDependencyFactoryNative_notifyIceCandidate(
env, java_object_.obj(),
@@ -62,29 +62,27 @@ class PeerConnectionDelegateImpl
ConvertUTF8ToJavaString(env, description).obj());
}
- virtual void OnLocalOfferCreatedAndSetSet(const std::string& description)
- override {
+ void OnLocalOfferCreatedAndSetSet(const std::string& description) override {
JNIEnv* env = AttachCurrentThread();
Java_SessionDependencyFactoryNative_notifyLocalOfferCreatedAndSetSet(
env, java_object_.obj(),
ConvertUTF8ToJavaString(env, description).obj());
}
- virtual void OnLocalAnswerCreatedAndSetSet(const std::string& description)
- override {
+ void OnLocalAnswerCreatedAndSetSet(const std::string& description) override {
JNIEnv* env = AttachCurrentThread();
Java_SessionDependencyFactoryNative_notifyLocalAnswerCreatedAndSetSet(
env, java_object_.obj(),
ConvertUTF8ToJavaString(env, description).obj());
}
- virtual void OnRemoteDescriptionSet() override {
+ void OnRemoteDescriptionSet() override {
JNIEnv* env = AttachCurrentThread();
Java_SessionDependencyFactoryNative_notifyRemoteDescriptionSet(
env, java_object_.obj());
}
- virtual void OnFailure(const std::string& description) override {
+ void OnFailure(const std::string& description) override {
JNIEnv* env = AttachCurrentThread();
Java_SessionDependencyFactoryNative_notifyConnectionFailure(
env, java_object_.obj(),
@@ -102,19 +100,19 @@ class DataChannelObserverImpl : public AbstractDataChannel::Observer {
java_object_.Reset(env, java_object);
}
- virtual void OnOpen() override {
+ void OnOpen() override {
JNIEnv* env = AttachCurrentThread();
Java_SessionDependencyFactoryNative_notifyChannelOpen(
env, java_object_.obj());
}
- virtual void OnClose() override {
+ void OnClose() override {
JNIEnv* env = AttachCurrentThread();
Java_SessionDependencyFactoryNative_notifyChannelClose(
env, java_object_.obj());
}
- virtual void OnMessage(const void* data, size_t length) override {
+ void OnMessage(const void* data, size_t length) override {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jobject> byte_buffer(

Powered by Google App Engine
This is Rietveld 408576698