Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: components/crash/browser/crash_dump_manager_android.h

Issue 893303003: Update {virtual,override,final} to follow C++11 style. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/cronet/android/cronet_url_request_context_adapter.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_ 5 #ifndef COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
6 #define COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_ 6 #define COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 21 matching lines...) Expand all
32 // processes and take the appropriate action when the render process terminates. 32 // processes and take the appropriate action when the render process terminates.
33 class CrashDumpManager : public content::BrowserChildProcessObserver, 33 class CrashDumpManager : public content::BrowserChildProcessObserver,
34 public content::NotificationObserver { 34 public content::NotificationObserver {
35 public: 35 public:
36 // The embedder should create a single instance of the CrashDumpManager. 36 // The embedder should create a single instance of the CrashDumpManager.
37 static CrashDumpManager* GetInstance(); 37 static CrashDumpManager* GetInstance();
38 38
39 // Should be created on the UI thread. 39 // Should be created on the UI thread.
40 explicit CrashDumpManager(const base::FilePath& crash_dump_dir); 40 explicit CrashDumpManager(const base::FilePath& crash_dump_dir);
41 41
42 virtual ~CrashDumpManager(); 42 ~CrashDumpManager() override;
43 43
44 // Returns a file that should be used to generate a minidump for the process 44 // Returns a file that should be used to generate a minidump for the process
45 // |child_process_id|. 45 // |child_process_id|.
46 base::File CreateMinidumpFile(int child_process_id); 46 base::File CreateMinidumpFile(int child_process_id);
47 47
48 private: 48 private:
49 typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath; 49 typedef std::map<int, base::FilePath> ChildProcessIDToMinidumpPath;
50 50
51 static void ProcessMinidump(const base::FilePath& minidump_path, 51 static void ProcessMinidump(const base::FilePath& minidump_path,
52 base::ProcessHandle pid); 52 base::ProcessHandle pid);
53 53
54 // content::BrowserChildProcessObserver implementation: 54 // content::BrowserChildProcessObserver implementation:
55 virtual void BrowserChildProcessHostDisconnected( 55 void BrowserChildProcessHostDisconnected(
56 const content::ChildProcessData& data) override; 56 const content::ChildProcessData& data) override;
57 virtual void BrowserChildProcessCrashed( 57 void BrowserChildProcessCrashed(
58 const content::ChildProcessData& data) override; 58 const content::ChildProcessData& data) override;
59 59
60 // NotificationObserver implementation: 60 // NotificationObserver implementation:
61 virtual void Observe(int type, 61 void Observe(int type,
62 const content::NotificationSource& source, 62 const content::NotificationSource& source,
63 const content::NotificationDetails& details) override; 63 const content::NotificationDetails& details) override;
64 64
65 // Called on child process exit (including crash). 65 // Called on child process exit (including crash).
66 void OnChildExit(int child_process_id, base::ProcessHandle pid); 66 void OnChildExit(int child_process_id, base::ProcessHandle pid);
67 67
68 content::NotificationRegistrar notification_registrar_; 68 content::NotificationRegistrar notification_registrar_;
69 69
70 // This map should only be accessed with its lock aquired as it is accessed 70 // This map should only be accessed with its lock aquired as it is accessed
71 // from the PROCESS_LAUNCHER and UI threads. 71 // from the PROCESS_LAUNCHER and UI threads.
72 base::Lock child_process_id_to_minidump_path_lock_; 72 base::Lock child_process_id_to_minidump_path_lock_;
73 ChildProcessIDToMinidumpPath child_process_id_to_minidump_path_; 73 ChildProcessIDToMinidumpPath child_process_id_to_minidump_path_;
74 74
75 base::FilePath crash_dump_dir_; 75 base::FilePath crash_dump_dir_;
76 76
77 static CrashDumpManager* instance_; 77 static CrashDumpManager* instance_;
78 78
79 DISALLOW_COPY_AND_ASSIGN(CrashDumpManager); 79 DISALLOW_COPY_AND_ASSIGN(CrashDumpManager);
80 }; 80 };
81 81
82 } // namespace breakpad 82 } // namespace breakpad
83 83
84 #endif // COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_ 84 #endif // COMPONENTS_CRASH_BROWSER_CRASH_DUMP_MANAGER_ANDROID_H_
OLDNEW
« no previous file with comments | « no previous file | components/cronet/android/cronet_url_request_context_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698