Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 892613003: MIPS: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". Port c65ae4f10c7273956e88db433f626b26a1377caf BUG= Committed: https://crrev.com/320d42e58aed0dfbee4ac4721939aa6c3bbb4624 Cr-Commit-Position: refs/heads/master@{#26367}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove printf formatter changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -152 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-mips.cc View 7 chunks +73 lines, -73 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 6 chunks +52 lines, -52 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-01-30 15:51:40 UTC) #2
dusmil.imgtec
lgtm.
5 years, 10 months ago (2015-01-30 18:15:46 UTC) #3
paul.l...
not LGTM, small issue to fix. https://codereview.chromium.org/892613003/diff/1/test/cctest/test-assembler-mips64.cc File test/cctest/test-assembler-mips64.cc (right): https://codereview.chromium.org/892613003/diff/1/test/cctest/test-assembler-mips64.cc#newcode69 test/cctest/test-assembler-mips64.cc:69: ::printf("f() = %lld\n", ...
5 years, 10 months ago (2015-01-30 18:21:38 UTC) #4
balazs.kilvady
https://codereview.chromium.org/892613003/diff/1/test/cctest/test-assembler-mips64.cc File test/cctest/test-assembler-mips64.cc (right): https://codereview.chromium.org/892613003/diff/1/test/cctest/test-assembler-mips64.cc#newcode69 test/cctest/test-assembler-mips64.cc:69: ::printf("f() = %lld\n", res); On 2015/01/30 18:21:38, paul.l... wrote: ...
5 years, 10 months ago (2015-01-30 18:36:48 UTC) #5
paul.l...
LGTM, thanks!
5 years, 10 months ago (2015-01-30 18:37:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892613003/20001
5 years, 10 months ago (2015-01-30 18:42:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 19:13:33 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 19:13:52 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/320d42e58aed0dfbee4ac4721939aa6c3bbb4624
Cr-Commit-Position: refs/heads/master@{#26367}

Powered by Google App Engine
This is Rietveld 408576698