src/mips64/macro-assembler-mips64.h - Issue 892613003: MIPS: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/macro-assembler-mips64.h

Issue 892613003: MIPS: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove printf formatter changes. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips64/macro-assembler-mips64.h

diff --git a/src/mips64/macro-assembler-mips64.h b/src/mips64/macro-assembler-mips64.h

index cf0becec7a76a85c4d57684654f48de8a6f64343..1e25b334c77cc5b5e4f6cb3a083f149e0d9922fe 100644

--- a/src/mips64/macro-assembler-mips64.h

+++ b/src/mips64/macro-assembler-mips64.h

@@ -1132,7 +1132,7 @@ class MacroAssembler: public Assembler {

ld(type, FieldMemOperand(obj, HeapObject::kMapOffset));

lbu(type, FieldMemOperand(type, Map::kInstanceTypeOffset));

And(type, type, Operand(kIsNotStringMask));

- DCHECK_EQ(0, kStringTag);

+ DCHECK_EQ(0u, kStringTag);

return eq;

}

« no previous file with comments | « src/mips64/full-codegen-mips64.cc ('k') | src/mips64/macro-assembler-mips64.cc » ('j') | no next file with comments »