src/mips64/full-codegen-mips64.cc - Issue 892613003: MIPS: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/full-codegen-mips64.cc

Issue 892613003: MIPS: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_* macros.". (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove printf formatter changes. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips64/full-codegen-mips64.cc

diff --git a/src/mips64/full-codegen-mips64.cc b/src/mips64/full-codegen-mips64.cc

index 9e79bcbb56f6caaeff157808a5905a1f6eb979f1..eccd1f9238e06b444e387c423032d51525193106 100644

--- a/src/mips64/full-codegen-mips64.cc

+++ b/src/mips64/full-codegen-mips64.cc

@@ -1224,7 +1224,7 @@ void FullCodeGenerator::VisitForInStatement(ForInStatement* stmt) {

// For proxies, no filtering is done.

// TODO(rossberg): What if only a prototype is a proxy? Not specified yet.

- DCHECK_EQ(Smi::FromInt(0), 0);

+ DCHECK_EQ(static_cast<Smi*>(0), Smi::FromInt(0));

__ Branch(&update_each, eq, a2, Operand(zero_reg));

// Convert the entry to a string or (smi) 0 if it isn't a property

« no previous file with comments | « src/mips64/code-stubs-mips64.cc ('k') | src/mips64/macro-assembler-mips64.h » ('j') | no next file with comments »