Rename ServiceWorkerClients.getAll to matchAll in M42

Rename ServiceWorkerClients.getAll to matchAll in M42

For matchAll is a more fitting name than getAll. See:
https://github.com/slightlyoff/ServiceWorker/issues/610#issuecomment-71134823
We should give developers a deprecation period. So in M42
- Add deprecation message for getAll()
- Introduce matchAll()

BUG=451334

[Kunihiko Sakamoto, 2015-02-04 06:49:44]

Did you verify that getAll() shows deprecation message on console?
I doubt it because this method is used from service workers and UseCounter
doesn't work in shared/service workers (crbug.com/376039).

[Kunihiko Sakamoto, 2015-02-05 10:45:10]

I'm trying to support deprecation message in service workers.
https://codereview.chromium.org/901143002/
Please hold on until it lands.

[zhuoyu.qian, 2015-02-06 02:54:09]

On 2015/02/05 10:45:10, Kunihiko Sakamoto wrote:
> I'm trying to support deprecation message in service workers.
> https://codereview.chromium.org/901143002/
> Please hold on until it lands.

OK, I will hold on it.

[Kunihiko Sakamoto, 2015-02-09 10:34:51]

The deprecation message support has landed. Thanks for waiting.

Please remove NOTRY=true from the CL description. You shouldn't use it without a
special reason.

https://codereview.chromium.org/892053003/diff/1/Source/core/frame/UseCounter...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/892053003/diff/1/Source/core/frame/UseCounter...
Source/core/frame/UseCounter.cpp:845: return "ServiceWorkerClients.getAll() is
deprecated. Please use 'matchAll' instead";
The interface name exposed to user is not "ServiceWorkerClients", but "Clients".
Please update the message.
(For the enum name, "ServiceWorkerClientsGetAll" is good.)

[zhuoyu.qian, 2015-02-10 01:21:16]

On 2015/02/09 10:34:51, Kunihiko Sakamoto wrote:
> The deprecation message support has landed. Thanks for waiting.
> 
> Please remove NOTRY=true from the CL description. You shouldn't use it without
a
> special reason.
> 
>
https://codereview.chromium.org/892053003/diff/1/Source/core/frame/UseCounter...
> File Source/core/frame/UseCounter.cpp (right):
> 
>
https://codereview.chromium.org/892053003/diff/1/Source/core/frame/UseCounter...
> Source/core/frame/UseCounter.cpp:845: return "ServiceWorkerClients.getAll() is
> deprecated. Please use 'matchAll' instead";
> The interface name exposed to user is not "ServiceWorkerClients", but
"Clients".
> Please update the message.
> (For the enum name, "ServiceWorkerClientsGetAll" is good.)

I modified the patch according your comment, and rebased it. Please have a look
at it, Thank you.

[Kunihiko Sakamoto, 2015-02-10 01:30:39]

non-owner lgtm.

https://codereview.chromium.org/892053003/diff/20001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/892053003/diff/20001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.cpp:857: return "Clients.getAll() is deprecated.
Please use 'matchAll' instead";
Nit: add a period at the end of sentence.

[zhuoyu.qian, 2015-02-10 01:33:21]

New patchsets have been uploaded after l-g-t-m from ksakamoto@chromium.org

[zhuoyu.qian, 2015-02-10 01:36:00]

zhuoyu.qian@samsung.com changed reviewers:
+ dominicc@chromium.org
- ksakamoto@chromium.org

[zhuoyu.qian, 2015-02-13 06:20:03]

--Kunihiko Sakamoto

[falken, 2015-02-13 10:15:59]

falken@chromium.org changed reviewers:
+ falken@chromium.org

[falken, 2015-02-13 10:16:00]

lgtm with nits

Please add a link to https://github.com/slightlyoff/ServiceWorker/issues/610 in
the issue description.

https://codereview.chromium.org/892053003/diff/60001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/892053003/diff/60001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.cpp:861: return "Clients.getAll() is deprecated and
will no longer work in Chrome 43. Please use 'matchAll' instead";
nit: Please add a period at the end of the sentence and a newline here.

https://codereview.chromium.org/892053003/diff/60001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerClients.cpp (right):

https://codereview.chromium.org/892053003/diff/60001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.cpp:57: // Deprecated, please
use matchAll instead
nit: add a period

https://codereview.chromium.org/892053003/diff/60001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerClients.h (right):

https://codereview.chromium.org/892053003/diff/60001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.h:24: // DEPRECATED, please
use matchAll instead
nit: add a period to end of the comment. Also, add a link to crbug.com/451334

[zhuoyu.qian, 2015-02-13 10:40:37]

New patchsets have been uploaded after l-g-t-m from falken@chromium.org

[zhuoyu.qian, 2015-02-13 10:47:06]

Change as falken comment.

https://codereview.chromium.org/892053003/diff/60001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/892053003/diff/60001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.cpp:861: return "Clients.getAll() is deprecated and
will no longer work in Chrome 43. Please use 'matchAll' instead";
On 2015/02/13 10:15:59, falken wrote:
> nit: Please add a period at the end of the sentence and a newline here.

Done.

https://codereview.chromium.org/892053003/diff/60001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerClients.cpp (right):

https://codereview.chromium.org/892053003/diff/60001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.cpp:57: // Deprecated, please
use matchAll instead
On 2015/02/13 10:15:59, falken wrote:
> nit: add a period

Done.

https://codereview.chromium.org/892053003/diff/60001/Source/modules/servicewo...
File Source/modules/serviceworkers/ServiceWorkerClients.h (right):

https://codereview.chromium.org/892053003/diff/60001/Source/modules/servicewo...
Source/modules/serviceworkers/ServiceWorkerClients.h:24: // DEPRECATED, please
use matchAll instead
On 2015/02/13 10:16:00, falken wrote:
> nit: add a period to end of the comment. Also, add a link to crbug.com/451334

Done.

[dominicc (has gone to gerrit), 2015-02-16 06:55:59]

dominicc@chromium.org changed reviewers:
+ ksakamoto@chromium.org
- dominicc@chromium.org

[zhuoyu.qian, 2015-02-16 08:00:03]

The CQ bit was checked by zhuoyu.qian@samsung.com

[commit-bot: I haz the power, 2015-02-16 08:00:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/892053003/80001

[commit-bot: I haz the power, 2015-02-16 08:05:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-16 08:05:28]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

[zhuoyu.qian, 2015-02-16 08:33:56]

zhuoyu.qian@samsung.com changed reviewers:
+ kinuko@chromium.org

[zhuoyu.qian, 2015-02-16 08:33:57]

Hi kinuko, I'd like you to do a code review for Source/core/frame/UseCounter.
Thank you!

[kinuko, 2015-02-16 09:47:18]

lgtm

https://codereview.chromium.org/892053003/diff/80001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/892053003/diff/80001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.cpp:861: return "Clients.getAll() is deprecated and
will no longer work in Chrome 43. Please use 'matchAll' instead.";
nit: I'd use single quote for Clients.getAll() too for consistency
('Clients.getAll()')
nit: matchAll -> Clients.matchAll() for better clarity?

[falken, 2015-02-18 06:58:37]

zhuoyu.qian@, what's going on with this patch? Can you land it today or
tomorrow, as the M42 branch cut is expected soon?

https://codereview.chromium.org/892053003/diff/80001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.cpp (right):

https://codereview.chromium.org/892053003/diff/80001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.cpp:861: return "Clients.getAll() is deprecated and
will no longer work in Chrome 43. Please use 'matchAll' instead.";
I don't think the Blink error message should mention "Chrome" as there are other
embedders. So please remove the "will no longer work..." part.

https://codereview.chromium.org/892053003/diff/80001/Source/core/frame/UseCou...
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/892053003/diff/80001/Source/core/frame/UseCou...
Source/core/frame/UseCounter.h:632: ServiceWorkerClientsGetAll = 690,
You'll have to rebase as 690 was recently taken.

[Kunihiko Sakamoto, 2015-02-20 02:15:08]

zhuoyu.qian@ seems not active for the last few days (because of Chinese new
year, perhaps?).
To make this in M42, I've made a new patch based on this, with comments
addressed and rebased.

https://codereview.chromium.org/944583003

Zhuoyu, thank you for your patch and sorry for hijacking it.

[zhuoyu.qian, 2015-02-25 00:33:59]

On 2015/02/20 02:15:08, Kunihiko Sakamoto wrote:
> zhuoyu.qian@ seems not active for the last few days (because of Chinese new
> year, perhaps?).
> To make this in M42, I've made a new patch based on this, with comments
> addressed and rebased.
> 
> https://codereview.chromium.org/944583003
> 
> Zhuoyu, thank you for your patch and sorry for hijacking it.

That's all right. I'm glad you pay attention to my CL. Thank you!