Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 892053003: Rename ServiceWorkerClients.getAll to matchAll in M42 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: edit for nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/UseCounter.cpp
diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp
index 81a7cf992ef4be1f9d8f0b60282eeef8c4518f77..6bf9cc0fb1da8bd4170f405dacbe7aafa736e3ad 100644
--- a/Source/core/frame/UseCounter.cpp
+++ b/Source/core/frame/UseCounter.cpp
@@ -857,6 +857,9 @@ String UseCounter::deprecationMessage(Feature feature)
case SVGSVGElementUnsuspendRedrawAll:
return "'SVGSVGElement.unsuspendRedrawAll()' is deprecated, please do not use it. It is a no-op, as per SVG2 (https://svgwg.org/svg2-draft/struct.html#__svg__SVGSVGElement__unsuspendRedrawAll).";
+ case ServiceWorkerClientsGetAll:
+ return "Clients.getAll() is deprecated and will no longer work in Chrome 43. Please use 'matchAll' instead.";
kinuko 2015/02/16 09:47:18 nit: I'd use single quote for Clients.getAll() too
falken 2015/02/18 06:58:37 I don't think the Blink error message should menti
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();

Powered by Google App Engine
This is Rietveld 408576698