Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 944583003: Deprecate Clients.getAll and introduce Clients.matchAll (Closed)

Created:
5 years, 10 months ago by Kunihiko Sakamoto
Modified:
5 years, 10 months ago
Reviewers:
kinuko, falken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Deprecate Clients.getAll and introduce Clients.matchAll Clients.getAll has been renamed to Clients.matchAll (https://github.com/slightlyoff/ServiceWorker/issues/610). This patch adds deprecation message for getAll() and introduces matchAll(). The plan is to remove getAll() in M43. Original patch from zhuoyu.qian@samsung.com (https://codereview.chromium.org/892053003/) BUG=451334 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190535

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Clients.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Kunihiko Sakamoto
5 years, 10 months ago (2015-02-20 02:16:17 UTC) #2
falken
lgtm
5 years, 10 months ago (2015-02-20 02:28:35 UTC) #3
kinuko
On 2015/02/20 02:28:35, falken wrote: > lgtm lgtm2
5 years, 10 months ago (2015-02-20 02:33:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944583003/1
5 years, 10 months ago (2015-02-20 03:09:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/27112)
5 years, 10 months ago (2015-02-20 03:49:16 UTC) #8
Kunihiko Sakamoto
On 2015/02/20 03:49:16, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-02-20 03:56:09 UTC) #9
kinuko
Yup, sorry... lgtm 2!
5 years, 10 months ago (2015-02-20 04:14:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944583003/1
5 years, 10 months ago (2015-02-20 04:19:54 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 06:48:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190535

Powered by Google App Engine
This is Rietveld 408576698