Chromium Code Reviews

Issue 891893002: Disable chrome target and tests on Windows. (Closed)

Created:
5 years, 10 months ago by brettw
Modified:
5 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable chrome target and tests on Windows. The bots don't have the capacity to link these targets. TBR=dpranke Committed: https://crrev.com/6bb47923233d145ffd17a9d4aa72dfee059e468f Cr-Commit-Position: refs/heads/master@{#314065}

Patch Set 1 #

Patch Set 2 : Try #2 with a flag and a dummy chrome target #

Unified diffs Side-by-side diffs Stats (+14 lines, -2 lines)
M build/config/BUILDCONFIG.gn View 1 chunk +5 lines, -0 lines 0 comments
M chrome/BUILD.gn View 1 chunk +8 lines, -1 line 0 comments
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891893002/1
5 years, 10 months ago (2015-01-31 07:12:51 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/3652)
5 years, 10 months ago (2015-01-31 08:03:51 UTC) #5
Dirk Pranke
On 2015/01/31 08:03:51, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-01-31 18:04:52 UTC) #6
Dirk Pranke
On 2015/01/31 18:04:52, Dirk Pranke wrote: > Looks like a couple of other targets need ...
5 years, 10 months ago (2015-01-31 18:22:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891893002/20001
5 years, 10 months ago (2015-01-31 18:34:57 UTC) #9
Dirk Pranke
On 2015/01/31 18:34:57, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 10 months ago (2015-01-31 18:49:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-31 20:19:05 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-01-31 20:20:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6bb47923233d145ffd17a9d4aa72dfee059e468f
Cr-Commit-Position: refs/heads/master@{#314065}

Powered by Google App Engine