chrome/BUILD.gn - Issue 891893002: Disable chrome target and tests on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 891893002: Disable chrome target and tests on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try #2 with a flag and a dummy chrome target Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index e85c1daa41ea794dc45e6c5319836e7fe0bf5141..9341384167efc76b35893ac38a98c774eef3ea10 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -12,7 +12,14 @@ if (is_android) {

import("//build/config/android/rules.gni")

}

-if (!is_android) {

+if (is_win && !link_chrome_on_windows) {

+ # When linking is disabled on Windows, create a dummy Chrome target to

+ # make targets work that depend on Chrome.

+ group("chrome") {

+ }

+if (!is_android && (!is_win || link_chrome_on_windows)) {

# TODO(GYP) for Windows need to the the reorder-imports step which probably

# means adding another target and renaming this to chrome_initial like in GYP.

executable("chrome") {

« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »