Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 875123003: Disable chrome target and tests on Windows. (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, Slava Chigrin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable chrome target and tests on Windows. The bots don't have the capacity to link these targets. TBR=brettw

Patch Set 1 #

Patch Set 2 : disable chrome_elf_unittests, test_registrar also #

Patch Set 3 : disable ash targets that need test_registrar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -249 lines) Patch
M ash/BUILD.gn View 1 2 1 chunk +208 lines, -204 lines 0 comments Download
M chrome/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M chrome_elf/BUILD.gn View 1 1 chunk +31 lines, -27 lines 0 comments Download
M win8/BUILD.gn View 1 1 chunk +20 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/875123003/20001
5 years, 10 months ago (2015-01-31 18:04:57 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_rel/builds/3733)
5 years, 10 months ago (2015-01-31 18:11:21 UTC) #4
Dirk Pranke
On 2015/01/31 18:11:21, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 10 months ago (2015-01-31 18:20:52 UTC) #5
Dirk Pranke
5 years, 10 months ago (2015-01-31 18:21:18 UTC) #6
On 2015/01/31 18:20:52, Dirk Pranke wrote:
> 
> I give up for now ... there's a cascade of dependencies, and finding them w/o
a
> win bot to test this on locally at the moment is a bit tedious. I'm going to
> revert the original patch for now.

See https://codereview.chromium.org/886243002/

Powered by Google App Engine
This is Rietveld 408576698