Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 891693002: [base] Further improve the logging facility.

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[base] Further improve the logging facility. - Make DumpBacktrace() private. - Get rid of DCHECK_RESULT. - Initial support for stream parameters. R=svenpanne@chromium.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment. #

Patch Set 3 : Android GCC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -55 lines) Patch
M src/base/logging.h View 1 7 chunks +140 lines, -40 lines 0 comments Download
M src/base/logging.cc View 1 2 5 chunks +40 lines, -6 lines 0 comments Download
M src/checks.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/jsregexp.cc View 5 chunks +15 lines, -5 lines 0 comments Download
M test/unittests/base/logging-unittest.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Benedikt Meurer
5 years, 10 months ago (2015-01-30 11:33:13 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-01-30 11:33:32 UTC) #2
Sven Panne
LGTM with a nit https://codereview.chromium.org/891693002/diff/1/src/base/logging.h File src/base/logging.h (right): https://codereview.chromium.org/891693002/diff/1/src/base/logging.h#newcode99 src/base/logging.h:99: #else // DEBUG Wrong comment
5 years, 10 months ago (2015-01-30 11:39:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891693002/20001
5 years, 10 months ago (2015-01-30 11:42:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891693002/40001
5 years, 10 months ago (2015-01-30 11:55:27 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 12:23:10 UTC) #10 
Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2459)

Powered by Google App Engine
This is Rietveld 408576698