Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: src/jsregexp.cc

Issue 891693002: [base] Further improve the logging facility. Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Android GCC Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/checks.h ('k') | test/unittests/base/logging-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/jsregexp.cc
diff --git a/src/jsregexp.cc b/src/jsregexp.cc
index 63c7a504de04380e5a4b64481e2500eac72685ad..f308a7983c19340b27788aaf817f2bddcbab0912 100644
--- a/src/jsregexp.cc
+++ b/src/jsregexp.cc
@@ -5598,7 +5598,9 @@ void DispatchTable::AddRange(CharacterRange full_range, int value,
if (tree()->is_empty()) {
// If this is the first range we just insert into the table.
ZoneSplayTree<Config>::Locator loc;
- DCHECK_RESULT(tree()->Insert(current.from(), &loc));
+ bool result = tree()->Insert(current.from(), &loc);
+ DCHECK(result);
+ USE(result);
loc.set_value(Entry(current.from(), current.to(),
empty()->Extend(value, zone)));
return;
@@ -5624,7 +5626,9 @@ void DispatchTable::AddRange(CharacterRange full_range, int value,
// to the map and let the next step deal with merging it with
// the range we're adding.
ZoneSplayTree<Config>::Locator loc;
- DCHECK_RESULT(tree()->Insert(right.from(), &loc));
+ bool result = tree()->Insert(right.from(), &loc);
+ DCHECK(result);
+ USE(result);
loc.set_value(Entry(right.from(),
right.to(),
entry->out_set()));
@@ -5640,7 +5644,9 @@ void DispatchTable::AddRange(CharacterRange full_range, int value,
// then we have to add a range covering just that space.
if (current.from() < entry->from()) {
ZoneSplayTree<Config>::Locator ins;
- DCHECK_RESULT(tree()->Insert(current.from(), &ins));
+ bool result = tree()->Insert(current.from(), &ins);
+ DCHECK(result);
+ USE(result);
ins.set_value(Entry(current.from(),
entry->from() - 1,
empty()->Extend(value, zone)));
@@ -5651,7 +5657,9 @@ void DispatchTable::AddRange(CharacterRange full_range, int value,
// we have to snap the right part off and add it separately.
if (entry->to() > current.to()) {
ZoneSplayTree<Config>::Locator ins;
- DCHECK_RESULT(tree()->Insert(current.to() + 1, &ins));
+ bool result = tree()->Insert(current.to() + 1, &ins);
+ DCHECK(result);
+ USE(result);
ins.set_value(Entry(current.to() + 1,
entry->to(),
entry->out_set()));
@@ -5671,7 +5679,9 @@ void DispatchTable::AddRange(CharacterRange full_range, int value,
} else {
// There is no overlap so we can just add the range
ZoneSplayTree<Config>::Locator ins;
- DCHECK_RESULT(tree()->Insert(current.from(), &ins));
+ bool result = tree()->Insert(current.from(), &ins);
+ DCHECK(result);
+ USE(result);
ins.set_value(Entry(current.from(),
current.to(),
empty()->Extend(value, zone)));
« no previous file with comments | « src/checks.h ('k') | test/unittests/base/logging-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698