[base] Further improve the logging facility.

test/unittests/base/logging-unittest.cc

Index: test/unittests/base/logging-unittest.cc
diff --git a/test/unittests/base/logging-unittest.cc b/test/unittests/base/logging-unittest.cc
index 918feb114bbbfdebd508600188acbcf38b7eff10..4d15175bb7a6ca0f4c40d18f3fdb57adb7145626 100644
--- a/test/unittests/base/logging-unittest.cc
+++ b/test/unittests/base/logging-unittest.cc
@@ -5,8 +5,23 @@
 #include "src/base/logging.h"
 #include "testing/gtest-support.h"
 
+#ifdef DEBUG
+#define DISABLE_IN_RELEASE(Name) Name
+#else
+#define DISABLE_IN_RELEASE(Name) DISABLED_##Name
+#endif
+
 namespace v8 {
 namespace base {
+namespace logging {
+
+TEST(LoggingDeathTest, DISABLE_IN_RELEASE(CheckFailureWithMessage)) {
+  ASSERT_DEATH_IF_SUPPORTED({ CHECK(false) << "This is a message"; },
+                            "This is a message");
+  ASSERT_DEATH_IF_SUPPORTED({ CHECK_EQ(0, 1) << "This is stupid"; },
+                            "This is stupid");
+}
+
 
 TEST(LoggingTest, CheckEQImpl) {
   EXPECT_EQ(nullptr, CheckEQImpl(0.0, 0.0, ""));
@@ -15,5 +30,6 @@ TEST(LoggingTest, CheckEQImpl) {
   EXPECT_EQ(nullptr, CheckEQImpl(-0.0, -0.0, ""));
 }
 
+}  // namespace logging
 }  // namespace base
 }  // namespace v8