Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 891603002: Removes the name service from the service runtime (Closed)

Created:
5 years, 10 months ago by Petr Hosek
Modified:
5 years, 10 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Removes the name service from the service runtime BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST=trybots Committed: https://chromium.googlesource.com/native_client/src/native_client/+/34c5a6aae1ebf3f2034ec96472b344e9a85a49ed

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixes code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -880 lines) Patch
M SConstruct View 1 chunk +0 lines, -1 line 0 comments Download
M src/public/imc_syscalls.h View 1 chunk +0 lines, -10 lines 0 comments Download
D src/public/name_service.h View 1 1 chunk +0 lines, -71 lines 0 comments Download
M src/trusted/debug_stub/target.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/reverse_service/reverse_service.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/trusted/service_runtime/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/service_runtime/build.scons View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/service_runtime/elf_util.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/include/bits/nacl_syscalls.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/service_runtime/nacl_bootstrap_channel_error_reporter.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_common.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_common.c View 1 chunk +0 lines, -51 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_list.c View 2 chunks +0 lines, -2 lines 0 comments Download
D src/trusted/service_runtime/name_service/name_service.h View 1 chunk +0 lines, -130 lines 0 comments Download
D src/trusted/service_runtime/name_service/name_service.c View 1 chunk +0 lines, -457 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.h View 3 chunks +1 line, -8 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.c View 4 chunks +1 line, -19 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr_standard.c View 2 chunks +0 lines, -14 lines 0 comments Download
M src/trusted/service_runtime/sel_main_common.c View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/simple_service/build.scons View 1 chunk +0 lines, -2 lines 0 comments Download
M src/untrusted/nacl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/untrusted/nacl/nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/untrusted/nacl/nacl.scons View 1 chunk +0 lines, -1 line 0 comments Download
D src/untrusted/nacl/nameservice.c View 1 chunk +0 lines, -18 lines 0 comments Download
M src/untrusted/nacl/syscall_bindings_trampoline.h View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/nameservice/nacl.scons View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/nameservice/nameservice_test.c View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Petr Hosek
5 years, 10 months ago (2015-01-30 04:06:20 UTC) #2
Mark Seaborn
LGTM, but please wait for Jan to close https://code.google.com/p/nativeclient/issues/detail?id=4055 before committing this. https://codereview.chromium.org/891603002/diff/1/src/trusted/reverse_service/reverse_service.h File src/trusted/reverse_service/reverse_service.h ...
5 years, 10 months ago (2015-02-01 00:40:53 UTC) #3
Petr Hosek
https://codereview.chromium.org/891603002/diff/1/src/trusted/reverse_service/reverse_service.h File src/trusted/reverse_service/reverse_service.h (left): https://codereview.chromium.org/891603002/diff/1/src/trusted/reverse_service/reverse_service.h#oldcode18 src/trusted/reverse_service/reverse_service.h:18: #include "native_client/src/public/name_service.h" On 2015/02/01 00:40:53, Mark Seaborn wrote: > ...
5 years, 10 months ago (2015-02-01 01:16:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891603002/20001
5 years, 10 months ago (2015-02-02 22:32:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 22:33:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/34c5a6aae...

Powered by Google App Engine
This is Rietveld 408576698