Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Side by Side Diff: src/trusted/reverse_service/reverse_service.h

Issue 891603002: Removes the name service from the service runtime (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* -*- c++ -*- */ 1 /* -*- c++ -*- */
2 /* 2 /*
3 * Copyright (c) 2012 The Native Client Authors. All rights reserved. 3 * Copyright (c) 2012 The Native Client Authors. All rights reserved.
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef NATIVE_CLIENT_SRC_TRUSTED_REVERSE_SERVICE_REVERSE_SERVICE_H_ 8 #ifndef NATIVE_CLIENT_SRC_TRUSTED_REVERSE_SERVICE_REVERSE_SERVICE_H_
9 #define NATIVE_CLIENT_SRC_TRUSTED_REVERSE_SERVICE_REVERSE_SERVICE_H_ 9 #define NATIVE_CLIENT_SRC_TRUSTED_REVERSE_SERVICE_REVERSE_SERVICE_H_
10 10
11 #include <set> 11 #include <set>
12 12
13 #include "native_client/src/include/nacl_compiler_annotations.h" 13 #include "native_client/src/include/nacl_compiler_annotations.h"
14 #include "native_client/src/include/nacl_macros.h" 14 #include "native_client/src/include/nacl_macros.h"
15 #include "native_client/src/include/nacl_scoped_ptr.h" 15 #include "native_client/src/include/nacl_scoped_ptr.h"
16 #include "native_client/src/include/nacl_string.h" 16 #include "native_client/src/include/nacl_string.h"
17 17
18 #include "native_client/src/public/name_service.h"
Mark Seaborn 2015/02/01 00:40:53 Also remove src/public/name_service.h?
Petr Hosek 2015/02/01 01:16:05 Acknowledged.
19 #include "native_client/src/shared/platform/refcount_base.h" 18 #include "native_client/src/shared/platform/refcount_base.h"
20 #include "native_client/src/shared/platform/nacl_sync.h" 19 #include "native_client/src/shared/platform/nacl_sync.h"
21 #include "native_client/src/trusted/desc/nacl_desc_wrapper.h" 20 #include "native_client/src/trusted/desc/nacl_desc_wrapper.h"
22 #include "native_client/src/trusted/reverse_service/reverse_service_c.h" 21 #include "native_client/src/trusted/reverse_service/reverse_service_c.h"
23 #include "native_client/src/trusted/service_runtime/include/sys/errno.h" 22 #include "native_client/src/trusted/service_runtime/include/sys/errno.h"
24 23
25 struct NaClFileInfo; 24 struct NaClFileInfo;
26 25
27 namespace nacl { 26 namespace nacl {
28 27
29 class ReverseInterface : public RefCountBase { 28 class ReverseInterface : public RefCountBase {
30 public: 29 public:
31 virtual ~ReverseInterface() {} 30 virtual ~ReverseInterface() {}
32 31
33 // Startup handshake 32 // Startup handshake
34 virtual void StartupInitializationComplete() = 0; 33 virtual void StartupInitializationComplete() = 0;
35 34
36 // Name service use.
37 //
38 // Some of these functions require that the actual operation be done 35 // Some of these functions require that the actual operation be done
39 // in a different thread, so that the implementation of the 36 // in a different thread, so that the implementation of the
40 // interface will have to block the requesting thread. However, on 37 // interface will have to block the requesting thread. However, on
41 // surf away, the thread switch may get cancelled, and the 38 // surf away, the thread switch may get cancelled, and the
42 // implementation will have to reply with a failure indication. 39 // implementation will have to reply with a failure indication.
43 40
44 virtual void ReportCrash() = 0; 41 virtual void ReportCrash() = 0;
45 42
46 // Quota checking for files that were sent to the untrusted module. 43 // Quota checking for files that were sent to the untrusted module.
47 // TODO(sehr): remove the stub interface once the plugin provides one. 44 // TODO(sehr): remove the stub interface once the plugin provides one.
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 private: 95 private:
99 NACL_DISALLOW_COPY_AND_ASSIGN(ReverseService); 96 NACL_DISALLOW_COPY_AND_ASSIGN(ReverseService);
100 97
101 NaClReverseService* service_; 98 NaClReverseService* service_;
102 ReverseInterface* reverse_interface_; 99 ReverseInterface* reverse_interface_;
103 }; 100 };
104 101
105 } // namespace nacl 102 } // namespace nacl
106 103
107 #endif 104 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698