src/trusted/reverse_service/reverse_service.h - Issue 891603002: Removes the name service from the service runtime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/reverse_service/reverse_service.h

Issue 891603002: Removes the name service from the service runtime (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Fixes code review comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/trusted/reverse_service/reverse_service.h

diff --git a/src/trusted/reverse_service/reverse_service.h b/src/trusted/reverse_service/reverse_service.h

index c0ecd581971009645f0fe0b0b7eb50e4ec67579e..27b70f278ab5bdd12c8852da5c76cfcb8d6b1423 100644

--- a/src/trusted/reverse_service/reverse_service.h

+++ b/src/trusted/reverse_service/reverse_service.h

@@ -15,7 +15,6 @@

#include "native_client/src/include/nacl_scoped_ptr.h"

#include "native_client/src/include/nacl_string.h"

-#include "native_client/src/public/name_service.h"

#include "native_client/src/shared/platform/refcount_base.h"

#include "native_client/src/shared/platform/nacl_sync.h"

#include "native_client/src/trusted/desc/nacl_desc_wrapper.h"

@@ -33,8 +32,6 @@ class ReverseInterface : public RefCountBase {

// Startup handshake

virtual void StartupInitializationComplete() = 0;

- // Name service use.

- //

// Some of these functions require that the actual operation be done

// in a different thread, so that the implementation of the

// interface will have to block the requesting thread. However, on

« no previous file with comments | « src/trusted/debug_stub/target.cc ('k') | src/trusted/service_runtime/BUILD.gn » ('j') | no next file with comments »