Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 890903002: [turbofan] Fix OSR into functions where the expression stack is not empty. (Closed)

Created:
5 years, 10 months ago by titzer
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix OSR into functions where the expression stack is not empty. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/219018d1551125156f0b58b058e14cdc80ce70b1 Cr-Commit-Position: refs/heads/master@{#26376}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -44 lines) Patch
M src/compiler.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 6 chunks +12 lines, -7 lines 0 comments Download
M src/compiler/frame.h View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 4 chunks +6 lines, -10 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/osr.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
titzer
5 years, 10 months ago (2015-01-30 13:03:39 UTC) #1
Michael Starzinger
LGTM, just one suggestion. https://codereview.chromium.org/890903002/diff/20001/src/compiler/frame.h File src/compiler/frame.h (right): https://codereview.chromium.org/890903002/diff/20001/src/compiler/frame.h#newcode84 src/compiler/frame.h:84: int osr_stack_slots_; nit: s/osr_stack_slots_/osr_stack_slot_count_/
5 years, 10 months ago (2015-01-30 14:46:17 UTC) #2
titzer
On 2015/01/30 14:46:17, Michael Starzinger wrote: > LGTM, just one suggestion. > > https://codereview.chromium.org/890903002/diff/20001/src/compiler/frame.h > ...
5 years, 10 months ago (2015-02-02 08:45:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890903002/40001
5 years, 10 months ago (2015-02-02 08:57:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/1564)
5 years, 10 months ago (2015-02-02 09:28:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/890903002/60001
5 years, 10 months ago (2015-02-02 09:49:22 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-02 10:20:07 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 10:20:21 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/219018d1551125156f0b58b058e14cdc80ce70b1
Cr-Commit-Position: refs/heads/master@{#26376}

Powered by Google App Engine
This is Rietveld 408576698