Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 889843003: [turbofan] Don't allocate UnallocatedOperands in Zone memory during instruction selection (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't allocate UnallocatedOperands in Zone memory during instruction selection R=bmeurer@chromium.org Committed: https://crrev.com/4116900d8fbac6eeaa1177eb489bc581efc7844f Cr-Commit-Position: refs/heads/master@{#26424}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -507 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 2 24 chunks +59 lines, -60 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 14 chunks +22 lines, -20 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 20 chunks +31 lines, -31 lines 0 comments Download
M src/compiler/instruction.h View 1 2 3 14 chunks +34 lines, -18 lines 0 comments Download
M src/compiler/instruction.cc View 1 3 chunks +9 lines, -16 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 3 chunks +33 lines, -30 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 11 chunks +55 lines, -53 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 2 chunks +80 lines, -81 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 13 chunks +41 lines, -39 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 15 chunks +43 lines, -41 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 17 chunks +27 lines, -26 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 2 chunks +20 lines, -32 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.h View 1 1 chunk +20 lines, -20 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 13 chunks +35 lines, -36 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
dcarney
ptal, i'll do this other arches if the approach is okay
5 years, 10 months ago (2015-01-30 13:01:52 UTC) #2
dcarney
ok, version 2
5 years, 10 months ago (2015-02-02 15:19:03 UTC) #3
Benedikt Meurer
LGTM
5 years, 10 months ago (2015-02-04 11:18:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889843003/20001
5 years, 10 months ago (2015-02-04 11:19:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/1104) v8_linux64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2649)
5 years, 10 months ago (2015-02-04 11:22:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889843003/40001
5 years, 10 months ago (2015-02-04 11:43:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/1076)
5 years, 10 months ago (2015-02-04 11:57:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889843003/60001
5 years, 10 months ago (2015-02-04 12:16:05 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-04 12:38:59 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 12:39:18 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4116900d8fbac6eeaa1177eb489bc581efc7844f
Cr-Commit-Position: refs/heads/master@{#26424}

Powered by Google App Engine
This is Rietveld 408576698