[turbofan] Don't allocate UnallocatedOperands in Zone memory during instruction selection

src/compiler/instruction.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/common-operator.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/instruction.h"
 
 namespace v8 {
 namespace internal {
@@ skipping 101 matching lines @@
 
 
 bool ParallelMove::IsRedundant() const {
   for (int i = 0; i < move_operands_.length(); ++i) {
     if (!move_operands_[i].IsRedundant()) return false;
   }
   return true;
 }
 
 
-static void SetOperand(UnallocatedOperand* loc, InstructionOperand* value) {
-  if (value->IsUnallocated()) {
-    loc[0] = *UnallocatedOperand::cast(value);
-  } else {
-    InstructionOperand* casted = static_cast<InstructionOperand*>(loc);
-    casted[0] = *value;
-  }
-}
-
-
 Instruction::Instruction(InstructionCode opcode)
     : opcode_(opcode),
       bit_field_(OutputCountField::encode(0) | InputCountField::encode(0) |
                  TempCountField::encode(0) | IsCallField::encode(false) |
                  IsControlField::encode(false)),
       pointer_map_(NULL) {}
 
 
 Instruction::Instruction(InstructionCode opcode, size_t output_count,
-                         InstructionOperand** outputs, size_t input_count,
-                         InstructionOperand** inputs, size_t temp_count,
-                         InstructionOperand** temps)
+                         InstructionOperand* outputs, size_t input_count,
+                         InstructionOperand* inputs, size_t temp_count,
+                         InstructionOperand* temps)
     : opcode_(opcode),
       bit_field_(OutputCountField::encode(output_count) |
                  InputCountField::encode(input_count) |
                  TempCountField::encode(temp_count) |
                  IsCallField::encode(false) | IsControlField::encode(false)),
       pointer_map_(NULL) {
   size_t offset = 0;
   for (size_t i = 0; i < output_count; ++i) {
-    SetOperand(&operands_[offset++], outputs[i]);
+    DCHECK(!outputs[i].IsInvalid());
+    operands_[offset++] = outputs[i];
   }
   for (size_t i = 0; i < input_count; ++i) {
-    SetOperand(&operands_[offset++], inputs[i]);
+    DCHECK(!inputs[i].IsInvalid());
+    operands_[offset++] = inputs[i];
   }
   for (size_t i = 0; i < temp_count; ++i) {
-    SetOperand(&operands_[offset++], temps[i]);
+    DCHECK(!temps[i].IsInvalid());
+    operands_[offset++] = temps[i];
   }
 }
 
 
 bool GapInstruction::IsRedundant() const {
   for (int i = GapInstruction::FIRST_INNER_POSITION;
        i <= GapInstruction::LAST_INNER_POSITION; i++) {
     if (parallel_moves_[i] != NULL && !parallel_moves_[i]->IsRedundant())
       return false;
   }
@@ skipping 567 matching lines @@
       os << " B" << succ_block->id();
     }
     os << "\n";
   }
   return os;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8