chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs - Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs

Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing dep and add a new one that should've been there already. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js ('K') | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs

diff --git a/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs b/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs

index 2289d4cb10264e6e96cdaaa9f3590d3833598ebd..d718fe84bf9132fcaaa8cfecf5d98e49e7efaab9 100644

--- a/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs

+++ b/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs

@@ -24,9 +24,10 @@ CvoxBrailleIntegrationUnitTest.prototype = {

'cvox.BrailleBackground',

'cvox.BrailleInputHandler',

'cvox.BrailleKeyCommand',

- 'cvox.BrailleUtil',

'cvox.ChromeBraille',

'cvox.ExpandingBrailleTranslator',

+ 'cvox.ValueSelectionSpan',

+ 'cvox.ValueSpan',

/** @override */

@@ -146,8 +147,8 @@ TEST_F('CvoxBrailleIntegrationUnitTest', 'Write', function() {

});

TEST_F('CvoxBrailleIntegrationUnitTest', 'WriteWithSpans', function() {

- var selectionSpan = new cvox.BrailleUtil.ValueSelectionSpan();

- var valueSpan = new cvox.BrailleUtil.ValueSpan(20);

+ var selectionSpan = new cvox.ValueSelectionSpan();

+ var valueSpan = new cvox.ValueSpan(20);

var toSend = cvox.NavBraille.fromText(

new cvox.Spannable('Hello', valueSpan));

toSend.text.setSpan(selectionSpan, 0, 0);