chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js - Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing dep and add a new one that should've been there already. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js ('K') | « chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs ('k') | chrome/browser/resources/chromeos/chromevox/walkers/structural_line_walker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

diff --git a/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js b/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

index 8495713e8a009eced9ddea86bc3ac0a0edee3209..b46a089df197de8e9956fffd09bd5fcd190aca33 100644

--- a/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

+++ b/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker.js

@@ -214,8 +214,7 @@ cvox.LayoutLineWalker.prototype.extend_ = function(start) {

cvox.LayoutLineWalker.prototype.appendBraille_ = function(

prevSel, sel, cur, braille) {

var item = this.subWalker_.getBraille(prevSel, cur).text;

- var valueSelectionSpan = item.getSpanInstanceOf(

- cvox.BrailleUtil.ValueSelectionSpan);

+ var valueSelectionSpan = item.getSpanInstanceOf(cvox.ValueSelectionSpan);

if (braille.text.getLength() > 0) {

braille.text.append(cvox.BrailleUtil.ITEM_SEPARATOR);