chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 889593002: Refactorings to reduce dependencies in ChromeVox 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Readd missing dep and add a new one that should've been there already. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js ('K') | « chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js ('k') | chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index f093bac9b3d85bb9477f08b080c0724f9dd53f9d..101e896d2d767232cb3e4f80d33e3cf07bb21949 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -13,9 +13,9 @@ goog.require('AutomationUtil.Dir');

goog.require('cursors.Cursor');

goog.require('cursors.Range');

goog.require('cursors.Unit');

-goog.require('cvox.BrailleUtil.ValueSelectionSpan');

-goog.require('cvox.BrailleUtil.ValueSpan');

goog.require('cvox.Spannable');

+goog.require('cvox.ValueSelectionSpan');

+goog.require('cvox.ValueSpan');

goog.scope(function() {

var Dir = AutomationUtil.Dir;

@@ -338,9 +338,9 @@ Output.prototype = {

} else {

startIndex = valueStart + selSpan.startIndex;

endIndex = valueStart + selSpan.endIndex;

- this.brailleBuffer_.setSpan(new cvox.BrailleUtil.ValueSpan(valueStart),

+ this.brailleBuffer_.setSpan(new cvox.ValueSpan(valueStart),

valueStart, valueEnd);

- this.brailleBuffer_.setSpan(new cvox.BrailleUtil.ValueSelectionSpan(),

+ this.brailleBuffer_.setSpan(new cvox.ValueSelectionSpan(),

startIndex, endIndex);

}